public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Kedareswara rao Appana <appana.durga.rao@xilinx.com>
Cc: dan.j.williams@intel.com, vinod.koul@intel.com,
	michal.simek@xilinx.com, soren.brinkmann@xilinx.com,
	appanad@xilinx.com, punnaia@xilinx.com,
	dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Srikanth Thokala <sthokal@xilinx.com>
Subject: Re: [PATCH v6] dma: Add Xilinx AXI Direct Memory Access Engine driver support
Date: Fri, 22 May 2015 12:10:14 +0200	[thread overview]
Message-ID: <1432289414.27695.90.camel@x220> (raw)
In-Reply-To: <1432228025-6515-1-git-send-email-appanad@xilinx.com>

Just a nit: a license mismatch.

On Thu, 2015-05-21 at 22:37 +0530, Kedareswara rao Appana wrote:
> --- /dev/null
> +++ b/drivers/dma/xilinx/xilinx_dma.c

> + * This program is free software: you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation, either version 2 of the License, or
> + * (at your option) any later version.

This states the license is GPL v2 or later.

> +MODULE_LICENSE("GPL v2");

And, according to include/linux/module.h, this states the license is
just GPL v2. So I think that either the comment at the top of this file
or the ident used in the MODULE_LICENSE() macro needs to change.

Thanks,


Paul Bolle


  reply	other threads:[~2015-05-22 10:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21 17:07 [PATCH v6] dma: Add Xilinx AXI Direct Memory Access Engine driver support Kedareswara rao Appana
2015-05-22 10:10 ` Paul Bolle [this message]
2015-06-08 11:20   ` Appana Durga Kedareswara Rao
2015-06-03  6:22 ` Appana Durga Kedareswara Rao
2015-06-08 11:14   ` Vinod Koul
2015-06-08 11:28     ` Appana Durga Kedareswara Rao
2015-06-08 15:34       ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432289414.27695.90.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=appana.durga.rao@xilinx.com \
    --cc=appanad@xilinx.com \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=punnaia@xilinx.com \
    --cc=soren.brinkmann@xilinx.com \
    --cc=sthokal@xilinx.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox