From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757156AbbEVMjg (ORCPT ); Fri, 22 May 2015 08:39:36 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:47738 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756267AbbEVMje (ORCPT ); Fri, 22 May 2015 08:39:34 -0400 X-AuditID: cbfee68d-f79106d00000728c-8e-555f238495d2 From: Vishnu Pratap Singh To: vishnu.ps@samsung.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Cc: cpgs@samsung.com Subject: [PATCH] init/do_mounts: Add create_dev() failure log Date: Fri, 22 May 2015 18:07:54 +0530 Message-id: <1432298274-7708-1-git-send-email-vishnu.ps@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOLMWRmVeSWpSXmKPExsWyRsSkTrdVOT7U4KCgxZz1a9gsXh7StLi8 aw6bxZS+u4wOLB4nZvxm8ejbsorR4/MmuQDmKC6blNSczLLUIn27BK6MSwt2sRdcYK84tuwT ewPjVLYuRk4OCQETidamzSwQtpjEhXvrgeJcHEICSxklVvUfBkpwgBUd/lgIEV/EKNF9vh+q qIlJorFjEStIN5uAocSG2UfYQWwRgRCJbXfXgW1gFhCR2P7kMtgGYQFbia0vHjOC2CwCqhKN M1cxg9i8Ai4SX2ZcYYdYpiAxZ5INyHwJgdtsEvuWn2SGqBeQ+Db5ENRBshKbDjBDHC0pcXDF DZYJjIILGBlWMYqmFiQXFCelFxnqFSfmFpfmpesl5+duYgSG3+l/z3p3MN4+YH2IUYCDUYmH 1+BgXKgQa2JZcWXuIUZToA0TmaVEk/OBQZ5XEm9obGZkYWpiamxkbmmmJM6rKPUzWEggPbEk NTs1tSC1KL6oNCe1+BAjEwenVAMjz0dG22OmGT2iKel5obfvbBb+q8HT4tufId2X//v3TP51 kRcyfjOumPsidM++VaIqYn+fti72vHfwxAtT5mdTt9+IPHT/RP/8Sc5ra/cUn1x04NGB57ml ud3cv+9InHmW8zA15Ljq7FK3y5o32vS2By26H1kYNidyjtAq+y2nfr/7+Wpz6gbB+UosxRmJ hlrMRcWJAP/VR+w6AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrELMWRmVeSWpSXmKPExsVy+t9jAd0W5fhQg965phZz1q9hs3h5SNPi 8q45bBZT+u4yOrB4nJjxm8Wjb8sqRo/Pm+QCmKMaGG0yUhNTUosUUvOS81My89JtlbyD453j Tc0MDHUNLS3MlRTyEnNTbZVcfAJ03TJzgLYpKZQl5pQChQISi4uV9O0wTQgNcdO1gGmM0PUN CYLrMTJAAwlrGDMuLdjFXnCBveLYsk/sDYxT2boYOTgkBEwkDn8s7GLkBDLFJC7cWw8U5uIQ EljEKNF9vh/KaWKSaOxYxApSxSZgKLFh9hF2EFtEIERi2911bCA2s4CIxPYnl1lAbGEBW4mt Lx4zgtgsAqoSjTNXMYPYvAIuEl9mXGGHWKwgMWeSzQRG7gWMDKsYRVMLkguKk9JzDfWKE3OL S/PS9ZLzczcxgsP7mdQOxpUNFocYBTgYlXh4DQ7GhQqxJpYVV+YeYpTgYFYS4V0oHB8qxJuS WFmVWpQfX1Sak1p8iNEUaPlEZinR5Hxg7OWVxBsam5ibGptamliYmFkqifOezPcJFRJITyxJ zU5NLUgtgulj4uCUamA0DeOTT27TK1wY5DZfSFEkYA7zC9UNapfDOn+Vsu8otQstmfFhx52z +zS8Dj/xOWD3UJt9Qs8qp79+2R2S3zVnLPJbxD+Lt6TdbO2pMBPnlTllosoaetOc1rrd/KxX udo/vkTQtvjTJoNlglw8P67XrEgLj7/z8UnngWtWHycUWU/Y5TbBSUOJpTgj0VCLuag4EQBn DA/WhQIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org if create_dev() function fails to create the root mount device (/dev/root), then it goes to panic as root device not found but there is no check/log present in case of failure, So i have added the log in case it fails to create the root device. It will help in debugging. Signed-off-by: Vishnu Pratap Singh --- init/do_mounts.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/init/do_mounts.h b/init/do_mounts.h index f5b978a..40c85e9 100644 --- a/init/do_mounts.h +++ b/init/do_mounts.h @@ -15,8 +15,12 @@ extern int root_mountflags; static inline int create_dev(char *name, dev_t dev) { + int ret; sys_unlink(name); - return sys_mknod(name, S_IFBLK|0600, new_encode_dev(dev)); + ret = sys_mknod(name, S_IFBLK|0600, new_encode_dev(dev)); + if(ret < 0) + printk(KERN_ERR " Failed to create %s device !! err: %d\n", name, ret); + return ret; } #if BITS_PER_LONG == 32 -- 1.7.9.5