Re: [PATCH v3 02/21] libnd, nfit: initial libnd infrastructure and NFIT support

[Toshi Kani <toshi.kani@hp.com>]

On Fri, 2015-05-22 at 14:58 +0000, Moore, Robert wrote:
> It looks to me that you are correct and I screwed up when I made those strings.
> The odd thing is that we had discussed this whole issue internally for a few days
>  -- then I went ahead and messed up the strings. I think my brain was going
> around in circles.

Yes, endianness is always fun... :-)

> Anyway, here is the latest info, please have a look:
> 
> 
> Below is the GUID for volatile memory region directly from the ACPI spec:
> 
> 
> { 0x7305944F, 0xFDDA, 0x44E3, 0xB1, 0x6C, 0x3F, 0x22, 0xD2, 0x52, 0xE5, 0xD0 }
> 
> Here is an example of ToUUID using a corrected version of the GUID string. Note that the ordering of the string is identical to the version in the ACPI spec:
> 
>       11:      Name (UUID, ToUUID ("7305944F-FDDA-44E3-B16C-3F22D252E5D0"))
> 
> 
> Here is the AML output of the ToUUID macro. Note that the first three fields are reversed, the rest of the string is left as-is (as per the ToUUID definition):
> 
> 00000024:  08 55 55 49 44 .........    ".UUID"
> 00000029:  11 13 0A 10 4F 94 05 73     "....O..s"
> 00000031:  DA FD E3 44 B1 6C 3F 22     "...D.l?""
> 00000039:  D2 52 E5 D0 ............    ".R.."
> 
> This is the important part:
> 
>            4F 94 05 73     "....O..s"
> 00000031:  DA FD E3 44 B1 6C 3F 22     "...D.l?""
> 00000039:  D2 52 E5 D0
> 
> 
> I believe that this is correct.

Looks good!

Thanks,
-Toshi