From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757804AbbEVPYk (ORCPT ); Fri, 22 May 2015 11:24:40 -0400 Received: from smtprelay0143.hostedemail.com ([216.40.44.143]:37275 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757331AbbEVPYj (ORCPT ); Fri, 22 May 2015 11:24:39 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::,RULES_HIT:41:355:379:541:599:960:973:979:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1543:1593:1594:1605:1711:1730:1747:1777:1792:2198:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:4383:4605:5007:6119:6248:6261:7903:9010:10004:10394:10400:10848:11026:11232:11658:11914:12296:12517:12519:12740:13255:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: cars89_2820d66e4d159 X-Filterd-Recvd-Size: 4460 Message-ID: <1432308274.29657.15.camel@perches.com> Subject: Re: [lustre-devel] [PATCH 2/3] staging:lustre: remove kernel defines in userland headers From: Joe Perches To: "Simmons, James A." Cc: "'Dan Carpenter'" , James Simmons , "devel@driverdev.osuosl.org" , James Simmons , James Simmons , Greg Kroah-Hartman , Linux Kernel Mailing List , Oleg Drokin , "HPDD-discuss@ml01.01.org" , "lustre-devel@lists.lustre.org" Date: Fri, 22 May 2015 08:24:34 -0700 In-Reply-To: References: <1432248378-28912-3-git-send-email-jsimmons@infradead.org> <20150522130019.GN4150@mwanda> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-05-22 at 15:12 +0000, Simmons, James A. wrote: > >> typedef struct lnet_peer { > >> - struct list_head lp_hashlist; /* chain on peer hash */ > >> - struct list_head lp_txq; /* messages blocking for tx credits */ > >> - struct list_head lp_rtrq; /* messages blocking for router credits */ > >> - struct list_head lp_rtr_list; /* chain on router list */ > >> - int lp_txcredits; /* # tx credits available */ > >> - int lp_mintxcredits; /* low water mark */ > >> - int lp_rtrcredits; /* # router credits */ > >> - int lp_minrtrcredits; /* low water mark */ > >> - unsigned int lp_alive:1; /* alive/dead? */ > >> - unsigned int lp_notify:1; /* notification outstanding? */ > >> - unsigned int lp_notifylnd:1; /* outstanding notification for LND? */ > >> - unsigned int lp_notifying:1; /* some thread is handling notification */ > >> - unsigned int lp_ping_notsent; /* SEND event outstanding from ping */ > >> - int lp_alive_count; /* # times router went dead<->alive */ > >> - long lp_txqnob; /* bytes queued for sending */ > >> - unsigned long lp_timestamp; /* time of last aliveness news */ > >> - unsigned long lp_ping_timestamp; /* time of last ping attempt */ > >> - unsigned long lp_ping_deadline; /* != 0 if ping reply expected */ > >> - unsigned long lp_last_alive; /* when I was last alive */ > >> - unsigned long lp_last_query; /* when lp_ni was queried last time */ > >> - lnet_ni_t *lp_ni; /* interface peer is on */ > >> - lnet_nid_t lp_nid; /* peer's NID */ > >> - int lp_refcount; /* # refs */ > >> - int lp_cpt; /* CPT this peer attached on */ > >> + /* chain on peer hash */ > >> + struct list_head lp_hashlist; > >> + /* messages blocking for tx credits */ > >> + struct list_head lp_txq; > >> + /* messages blocking for router credits */ > >> + struct list_head lp_rtrq; > >> + /* chain on router list */ > >> + struct list_head lp_rtr_list; > >> + /* # tx credits available */ > >> + int lp_txcredits; > >> + /* low water mark */ > >> + int lp_mintxcredits; > >> + /* # router credits */ > >> + int lp_rtrcredits; > >> + /* low water mark */ > >> + int lp_minrtrcredits; > >> + /* alive/dead? */ > >> + unsigned int lp_alive:1; > >> + /* notification outstanding? */ > >> + unsigned int lp_notify:1; > >> + /* outstanding notification for LND? */ > >> + unsigned int lp_notifylnd:1; > > > >This new block of declarations is uglier than the original. Don't make > >things uglier. > > Might be ugly but it makes checkpatch.pl happy. So it is a choice between > making checkpatch.pl happy about staying in the 80 character limit or looking > nice and chekpatch.pl being unhappy. I would choose looking nice every time. checkpatch is stupid. Please don't let it control you. Maybe it'd be better to add another --ignore type just for comments that extend longer than the maximum line length to checkpatch.