From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>, Ingo Molnar <mingo@redhat.com>
Cc: linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
adrian.hunter@intel.com, x86@kernel.org, hpa@zytor.com,
acme@infradead.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: [PATCH v1 2/7] perf/x86/intel/pt: Kill an unused variable
Date: Fri, 22 May 2015 18:30:21 +0300 [thread overview]
Message-ID: <1432308626-18845-3-git-send-email-alexander.shishkin@linux.intel.com> (raw)
In-Reply-To: <1432308626-18845-1-git-send-email-alexander.shishkin@linux.intel.com>
Currently, there's a set-but-not-used variable in setup_topa_index();
this patch gets rid of it. And while at it, fixes a style issue with
brackets around a one-line block.
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
arch/x86/kernel/cpu/perf_event_intel_pt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/cpu/perf_event_intel_pt.c b/arch/x86/kernel/cpu/perf_event_intel_pt.c
index ffe666c2c6..ac08b67c07 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_pt.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_pt.c
@@ -664,7 +664,7 @@ static void pt_buffer_setup_topa_index(struct pt_buffer *buf)
struct topa *cur = buf->first, *prev = buf->last;
struct topa_entry *te_cur = TOPA_ENTRY(cur, 0),
*te_prev = TOPA_ENTRY(prev, prev->last - 1);
- int pg = 0, idx = 0, ntopa = 0;
+ int pg = 0, idx = 0;
while (pg < buf->nr_pages) {
int tidx;
@@ -679,9 +679,9 @@ static void pt_buffer_setup_topa_index(struct pt_buffer *buf)
/* advance to next topa table */
idx = 0;
cur = list_entry(cur->list.next, struct topa, list);
- ntopa++;
- } else
+ } else {
idx++;
+ }
te_cur = TOPA_ENTRY(cur, idx);
}
--
2.1.4
next prev parent reply other threads:[~2015-05-22 15:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 15:30 [PATCH v1 0/7] perf/x86/intel/pt: Fixes and cleanups Alexander Shishkin
2015-05-22 15:30 ` [PATCH v1 1/7] perf: Disallow sparse AUX allocations for non-SG PMUs in overwrite mode Alexander Shishkin
2015-05-27 10:02 ` [tip:perf/core] " tip-bot for Alexander Shishkin
2015-05-22 15:30 ` Alexander Shishkin [this message]
2015-05-22 15:30 ` [PATCH v1 3/7] perf/x86/intel/pt: Untangle pt_buffer_reset_markers() Alexander Shishkin
2015-05-27 10:02 ` [tip:perf/core] " tip-bot for Alexander Shishkin
2015-05-22 15:30 ` [PATCH v1 4/7] perf/x86/intel/pt: Document pt_buffer_reset_markers() Alexander Shishkin
2015-05-22 15:30 ` [PATCH v1 5/7] perf/x86/intel/pt: Document pt_buffer_reset_offsets() Alexander Shishkin
2015-05-22 15:30 ` [PATCH v1 6/7] perf/x86/intel/pt: Kill pt_is_running() Alexander Shishkin
2015-05-22 15:30 ` [PATCH v1 7/7] perf/x86/intel/pt: Remove an extra variable declaration Alexander Shishkin
2015-05-27 10:08 ` [tip:perf/core] perf/x86/intel/pt: Remove redundant " tip-bot for Alexander Shishkin
2015-05-22 17:04 ` [PATCH v1 0/7] perf/x86/intel/pt: Fixes and cleanups Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432308626-18845-3-git-send-email-alexander.shishkin@linux.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=adrian.hunter@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).