From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>, Ingo Molnar <mingo@redhat.com>
Cc: linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
adrian.hunter@intel.com, x86@kernel.org, hpa@zytor.com,
acme@infradead.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: [PATCH v1 5/7] perf/x86/intel/pt: Document pt_buffer_reset_offsets()
Date: Fri, 22 May 2015 18:30:24 +0300 [thread overview]
Message-ID: <1432308626-18845-6-git-send-email-alexander.shishkin@linux.intel.com> (raw)
In-Reply-To: <1432308626-18845-1-git-send-email-alexander.shishkin@linux.intel.com>
Currently, the description of pt_buffer_reset_offsets() lacks information
about its calling constraints and ordering with regards to other buffer
management functions.
Add a clarification about when this function has to be called.
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
arch/x86/kernel/cpu/perf_event_intel_pt.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/perf_event_intel_pt.c b/arch/x86/kernel/cpu/perf_event_intel_pt.c
index b2746eafa0..40ba5e4312 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_pt.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_pt.c
@@ -705,7 +705,14 @@ static void pt_buffer_setup_topa_index(struct pt_buffer *buf)
* @head: Write pointer (aux_head) from AUX buffer.
*
* Find the ToPA table and entry corresponding to given @head and set buffer's
- * "current" pointers accordingly.
+ * "current" pointers accordingly. This is done after we have obtained the
+ * current aux_head position from a successful call to perf_aux_output_begin()
+ * to make sure the hardware is writing to the right place.
+ *
+ * This function modifies buf::{cur,cur_idx,output_off} that will be programmed
+ * into PT msrs when the tracing is enabled and buf::head and buf::data_size,
+ * which are used to determine INT and STOP markers' locations by a subsequent
+ * call to pt_buffer_reset_markers().
*/
static void pt_buffer_reset_offsets(struct pt_buffer *buf, unsigned long head)
{
--
2.1.4
next prev parent reply other threads:[~2015-05-22 15:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 15:30 [PATCH v1 0/7] perf/x86/intel/pt: Fixes and cleanups Alexander Shishkin
2015-05-22 15:30 ` [PATCH v1 1/7] perf: Disallow sparse AUX allocations for non-SG PMUs in overwrite mode Alexander Shishkin
2015-05-27 10:02 ` [tip:perf/core] " tip-bot for Alexander Shishkin
2015-05-22 15:30 ` [PATCH v1 2/7] perf/x86/intel/pt: Kill an unused variable Alexander Shishkin
2015-05-22 15:30 ` [PATCH v1 3/7] perf/x86/intel/pt: Untangle pt_buffer_reset_markers() Alexander Shishkin
2015-05-27 10:02 ` [tip:perf/core] " tip-bot for Alexander Shishkin
2015-05-22 15:30 ` [PATCH v1 4/7] perf/x86/intel/pt: Document pt_buffer_reset_markers() Alexander Shishkin
2015-05-22 15:30 ` Alexander Shishkin [this message]
2015-05-22 15:30 ` [PATCH v1 6/7] perf/x86/intel/pt: Kill pt_is_running() Alexander Shishkin
2015-05-22 15:30 ` [PATCH v1 7/7] perf/x86/intel/pt: Remove an extra variable declaration Alexander Shishkin
2015-05-27 10:08 ` [tip:perf/core] perf/x86/intel/pt: Remove redundant " tip-bot for Alexander Shishkin
2015-05-22 17:04 ` [PATCH v1 0/7] perf/x86/intel/pt: Fixes and cleanups Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432308626-18845-6-git-send-email-alexander.shishkin@linux.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=adrian.hunter@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).