From: Paul Bolle <pebolle@tiscali.nl>
To: Yakir Yang <ykk@rock-chips.com>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.de>,
Fabio Estevam <fabio.estevam@freescale.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Thierry Reding <treding@nvidia.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-kernel@vger.kernel.org, Inki Dae <inki.dae@samsung.com>,
Andy Yan <andy.yan@rock-chips.com>,
David Airlie <airlied@linux.ie>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ajay Kumar <ajaykumar.rs@samsung.com>,
Dave Airlie <airlied@redhat.com>
Subject: Re: [RESEND PATCH v1 2/2] drm: bridge/dw_hdmi-i2s-audio: add audio driver
Date: Mon, 25 May 2015 10:24:07 +0200 [thread overview]
Message-ID: <1432542247.27695.137.camel@x220> (raw)
In-Reply-To: <1432307696-7806-1-git-send-email-ykk@rock-chips.com>
Just a nit: a license mismatch.
On Fri, 2015-05-22 at 10:14 -0500, Yakir Yang wrote:
> --- /dev/null
> +++ b/drivers/gpu/drm/bridge/dw_hdmi-i2s-audio.c
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
This states the license is GPL v2.
> +MODULE_LICENSE("GPL");
And, according to include/linux/module.h, this states the license is GPL
v2 or later. So I think that either the comment at the top of this file
or the ident used in the MODULE_LICENSE() macro should change.
Paul Bolle
next prev parent reply other threads:[~2015-05-25 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 15:13 [RESEND PATCH v1 0/2] Add dw_hdmi i2s audio driver support Yakir Yang
2015-05-22 15:14 ` [RESEND PATCH v1 1/2] drm: bridge/dw_hdmi: rename dw_hdmi-ahb-audio.h to dw_hdmi-audio.h Yakir Yang
2015-05-22 15:14 ` [RESEND PATCH v1 2/2] drm: bridge/dw_hdmi-i2s-audio: add audio driver Yakir Yang
2015-05-25 8:24 ` Paul Bolle [this message]
2015-05-25 9:38 ` Yakir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432542247.27695.137.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=ajaykumar.rs@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=andy.yan@rock-chips.com \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@freescale.com \
--cc=gregkh@linuxfoundation.org \
--cc=inki.dae@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=tiwai@suse.de \
--cc=treding@nvidia.com \
--cc=ykk@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox