Re: [RFC v1] tree-wide: remove "select FW_LOADER" uses

Borislav Petkov
2015-05-22T06:53:51Z

On Fri, May 22, 2015 at 12:21:29AM +0200, Borislav Petkov wrote:
> On Thu, May 21, 2015 at 01:45:49PM -0700, Luis R. Rodriguez wrote:
> > The above history is just *one* set of reasons to remove all kernel
> > "select FW_LOADER" entries. Another simple reason is that since
> > FW_LOADER can only be disabled by an EXPERT and it defaults to y
> > its now a superfluous select. We will ensure things build for you
> > if using EXPERT but if you have selected EXPERT you should know
> > what run time requirements you need.
>
> Couple of notes only:

One thing I forgot last night: what about randconfigs? All that
functionality which selects FW_LOADER, won't boot anymore, right? I
mean, there are provisions to build fine even with FW_LOADER unset but
if you want to boot-test those kernels, you will artificially fail due
to missing request_firmware* things...

Yap, just triggered one:

$ make randconfig; grep -E "(MICROCODE|FW_LOADER)" .config
scripts/kconfig/conf --randconfig Kconfig
KCONFIG_SEED=0xE14FBE97
warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG which has unmet direct dependencies (USB_SUPPORT && USB && PM)
warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG which has unmet direct dependencies (USB_SUPPORT && USB && PM)
warning: (SND_SOC_INTEL_BYTCR_RT5640_MACH && SND_SOC_INTEL_CHT_BSW_RT5672_MACH && SND_SOC_INTEL_CHT_BSW_RT5645_MACH) selects SND_SST_IPC_ACPI which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && ACPI)
#
# configuration written to .config
#
CONFIG_MICROCODE=m
CONFIG_MICROCODE_INTEL=y
CONFIG_MICROCODE_AMD=y
CONFIG_MICROCODE_OLD_INTERFACE=y
# CONFIG_FW_LOADER is not set

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--