From: Ido Yariv <ido@wizery.com>
To: "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
Nandita Dukkipati <nanditad@google.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ido Yariv <ido@wizery.com>, Ido Yariv <idox.yariv@intel.com>
Subject: [PATCH] net: tcp: Fix a PTO timing granularity issue
Date: Tue, 26 May 2015 16:17:17 -0400 [thread overview]
Message-ID: <1432671437-19140-1-git-send-email-ido@wizery.com> (raw)
In-Reply-To: <1432663992.4060.286.camel@edumazet-glaptop2.roam.corp.google.com>
The Tail Loss Probe RFC specifies that the PTO value should be set to
max(2 * SRTT, 10ms), where SRTT is the smoothed round-trip time.
The PTO value is converted to jiffies, so the timer may expire
prematurely.
This is especially problematic on systems in which HZ <= 100, so work
around this by setting the timeout to at least 2 jiffies on such
systems.
The 10ms figure was originally selected based on tests performed with
the current implementation and HZ = 1000. Thus, leave the behavior on
systems with HZ > 100 unchanged.
Signed-off-by: Ido Yariv <idox.yariv@intel.com>
---
net/ipv4/tcp_output.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index 534e5fd..5321df8 100644
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -2208,6 +2208,9 @@ bool tcp_schedule_loss_probe(struct sock *sk)
timeout = max_t(u32, timeout,
(rtt + (rtt >> 1) + TCP_DELACK_MAX));
timeout = max_t(u32, timeout, msecs_to_jiffies(10));
+#if HZ <= 100
+ timeout = max_t(u32, timeout, 2);
+#endif
/* If RTO is shorter, just schedule TLP in its place. */
tlp_time_stamp = tcp_time_stamp + timeout;
--
2.1.0
next prev parent reply other threads:[~2015-05-26 20:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 14:25 [PATCH] net: tcp: Fix a PTO timing granularity issue Ido Yariv
2015-05-26 16:23 ` Eric Dumazet
2015-05-26 17:02 ` Ido Yariv
2015-05-26 17:13 ` Eric Dumazet
2015-05-26 17:55 ` Ido Yariv
2015-05-26 18:13 ` Eric Dumazet
2015-05-26 20:17 ` Ido Yariv [this message]
2015-05-27 11:36 ` David Laight
2015-05-27 13:41 ` Eric Dumazet
2015-05-27 14:40 ` Ido Yariv
2015-05-27 14:56 ` Eric Dumazet
2015-05-27 15:23 ` Ido Yariv
2015-05-27 16:23 ` Eric Dumazet
2015-05-27 16:54 ` Ido Yariv
2015-05-27 17:24 ` Eric Dumazet
2015-05-27 19:15 ` Ido Yariv
2015-05-28 4:37 ` Ido Yariv
2015-05-28 8:55 ` David Laight
2015-05-28 12:33 ` [PATCH v6] " Ido Yariv
2015-05-26 18:25 ` [PATCH] " Eric Dumazet
2015-05-26 19:39 ` Ido Yariv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432671437-19140-1-git-send-email-ido@wizery.com \
--to=ido@wizery.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=idox.yariv@intel.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=nanditad@google.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).