From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752298AbbE0Gzb (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 May 2015 02:55:31 -0400
Received: from lb2-smtp-cloud6.xs4all.net ([194.109.24.28]:52046 "EHLO
	lb2-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751185AbbE0Gz3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 May 2015 02:55:29 -0400
Message-ID: <1432709723.27695.210.camel@x220>
Subject: Re: [PATCH v4 3/5] dmaengine: pxa: add pxa dmaengine driver
From: Paul Bolle <pebolle@tiscali.nl>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Vinod Koul <vinod.koul@intel.com>, Jonathan Corbet <corbet@lwn.net>,
        Daniel Mack <daniel@zonque.org>,
        Haojian Zhuang <haojian.zhuang@gmail.com>, dmaengine@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Date: Wed, 27 May 2015 08:55:23 +0200
In-Reply-To: <87siaizguz.fsf@belgarion.home>
References: <1432589362-23241-1-git-send-email-robert.jarzmik@free.fr>
	 <1432589362-23241-3-git-send-email-robert.jarzmik@free.fr>
	 <1432625314.27695.200.camel@x220> <87siaizguz.fsf@belgarion.home>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2015-05-27 at 08:15 +0200, Robert Jarzmik wrote:
> Paul Bolle <pebolle@tiscali.nl> writes:
> > Was it actually intended for PXA_DMA to be tristate?
> It is designed to be a module, and in the "end" it will be a module.
> 
> What is important to understand is the 3 phases which are going to happen :
>  - phase 1 : state after this is merged
>              pxa_dma must be builtin, for legacy support (see
>              pxad_toggle_reserved_channel()).
>  - phase 2 : slowly, all the pxa drivers are converted to dmaengine
>  - phase 3 : after full conversion, the patch "add support for legacy
>              transition" is reverted.
>              There pxa_dma will become modular, and the tristate will appear.
> 
> In conclusion, it cannot be a module yet, but it will in the future.

Thanks for this explanation. So I didn't miss a comment or some remark
in a commit explanation, did I?


Paul Bolle