public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Borislav Petkov <bp@suse.de>, David Ahern <dsahern@gmail.com>,
	Don Zickus <dzickus@redhat.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Stephane Eranian <eranian@google.com>
Subject: [PATCH 14/25] perf tools: Remove redundant initialization of thread linkage members
Date: Wed, 27 May 2015 12:38:59 -0300	[thread overview]
Message-ID: <1432741150-28551-15-git-send-email-acme@kernel.org> (raw)
In-Reply-To: <1432741150-28551-1-git-send-email-acme@kernel.org>

From: Arnaldo Carvalho de Melo <acme@redhat.com>

A thread moves from a rb tree to a list, but can't be on both, because
those linkage members are in a union. This is leftover from when I was
debugging thread refcounting and had nuked that union.

It is harmless duplication, as RB_CLEAR_NODE() does again what
INIT_LIST_HEAD does.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-hmma9lmip6qlhzhgkhp9tzd1@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/thread.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c
index 16c28a37a9e4..28c4b746baa1 100644
--- a/tools/perf/util/thread.c
+++ b/tools/perf/util/thread.c
@@ -54,7 +54,6 @@ struct thread *thread__new(pid_t pid, pid_t tid)
 
 		list_add(&comm->list, &thread->comm_list);
 		atomic_set(&thread->refcnt, 0);
-		INIT_LIST_HEAD(&thread->node);
 		RB_CLEAR_NODE(&thread->rb_node);
 	}
 
@@ -70,7 +69,6 @@ void thread__delete(struct thread *thread)
 	struct comm *comm, *tmp;
 
 	BUG_ON(!RB_EMPTY_NODE(&thread->rb_node));
-	BUG_ON(!list_empty(&thread->node));
 
 	thread_stack__free(thread);
 
-- 
2.1.0


  parent reply	other threads:[~2015-05-27 15:43 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-27 15:38 [GIT PULL 00/25] perf/core improvements and fixes Arnaldo Carvalho de Melo
2015-05-27 15:38 ` [PATCH 01/25] perf tools: Separate the tests and tools in installation Arnaldo Carvalho de Melo
2015-05-27 15:38 ` [PATCH 02/25] perf tools: Fix function declarations needed by parse-events.y Arnaldo Carvalho de Melo
2015-05-27 15:38 ` [PATCH 03/25] perf tools: Fix parse_events_error dereferences Arnaldo Carvalho de Melo
2015-05-27 15:38 ` [PATCH 04/25] perf build: Fix libunwind feature detection on 32-bit x86 Arnaldo Carvalho de Melo
2015-05-27 15:38 ` [PATCH 05/25] perf session: Fix perf_session__peek_event() Arnaldo Carvalho de Melo
2015-05-27 15:38 ` [PATCH 06/25] perf hists: Reducing arguments of hist_entry_iter__add() Arnaldo Carvalho de Melo
2015-05-27 15:38 ` [PATCH 07/25] perf hists: Rename add_hist_entry to hists__findnew_entry Arnaldo Carvalho de Melo
2015-05-27 15:38 ` [PATCH 08/25] perf comm: Use atomic.h for refcounting Arnaldo Carvalho de Melo
2015-05-27 15:38 ` [PATCH 09/25] perf machine: Do not call map_groups__delete(), drop refcnt instead Arnaldo Carvalho de Melo
2015-05-27 15:38 ` [PATCH 10/25] perf tools: Fix dso__data_read_offset() file opening Arnaldo Carvalho de Melo
2015-05-27 15:38 ` [PATCH 11/25] perf tools: Get rid of dso__data_fd() from dso__data_size() Arnaldo Carvalho de Melo
2015-05-27 15:38 ` [PATCH 12/25] perf tools: Add dso__data_get/put_fd() Arnaldo Carvalho de Melo
2015-05-27 15:38 ` [PATCH 13/25] perf tools: Rename maps__next Arnaldo Carvalho de Melo
2015-05-27 15:38 ` Arnaldo Carvalho de Melo [this message]
2015-05-27 15:39 ` [PATCH 15/25] perf tools: Nuke unused map_groups__flush() Arnaldo Carvalho de Melo
2015-05-27 15:39 ` [PATCH 16/25] perf tools: Import rb_erase_init from block/ in the kernel sources Arnaldo Carvalho de Melo
2015-05-27 15:39 ` [PATCH 17/25] perf machine: Mark removed threads as such Arnaldo Carvalho de Melo
2015-05-27 15:39 ` [PATCH 18/25] perf tools: Leave DSO destruction to the map destruction Arnaldo Carvalho de Melo
2015-05-27 15:39 ` [PATCH 19/25] perf tools: Use maps__first()/map__next() Arnaldo Carvalho de Melo
2015-05-27 15:39 ` [PATCH 20/25] perf tools: Assign default value for some pointers Arnaldo Carvalho de Melo
2015-05-27 15:39 ` [PATCH 21/25] perf tools: Improve setting of gcc debug option Arnaldo Carvalho de Melo
2015-05-27 15:39 ` [PATCH 22/25] perf sched: Add option to merge like comms to lat output Arnaldo Carvalho de Melo
2015-05-27 15:39 ` [PATCH 23/25] perf tools: Disallow PMU events intel_pt and intel_bts until there is support Arnaldo Carvalho de Melo
2015-05-27 15:39 ` [PATCH 24/25] perf probe: Show the error reason comes from invalid DSO Arnaldo Carvalho de Melo
2015-05-27 15:39 ` [PATCH 25/25] perf probe: Fix an error when deleting probes successfully Arnaldo Carvalho de Melo
2015-05-27 16:43 ` [GIT PULL 00/25] perf/core improvements and fixes Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432741150-28551-15-git-send-email-acme@kernel.org \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=bp@suse.de \
    --cc=dsahern@gmail.com \
    --cc=dzickus@redhat.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox