From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Laurent Navet <laurent.navet@gmail.com>,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
Julia Lawall <julia.lawall@lip6.fr>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: gdm72xx: remove unneeded test
Date: Thu, 28 May 2015 01:06:35 -0700 [thread overview]
Message-ID: <1432800395.2846.205.camel@perches.com> (raw)
In-Reply-To: <20150528071444.GW11588@mwanda>
On Thu, 2015-05-28 at 10:14 +0300, Dan Carpenter wrote:
> On Wed, May 27, 2015 at 01:30:08PM -0700, Joe Perches wrote:
> > Perhaps all of the uses like:
> > goto <foo>;
> > <foo>:
> >
> > could be modified. There are ~150 in the kernel.
>
> Joe, these are a kind of style. You're just directing a newbie into a
> hornets nest. Laurant, don't do listen to Joe unless you like getting
> flamed.
Hey Dan.
I didn't direct anyone to do anything, but that's
why I added Julia to cc's.
Anyway, I think these are very equivalent style to
the repeated:
ret = foo();
if (ret < 0)
return ret;
...
ret = bar();
if (ret < 0)
return ret;
return ret;
and people seem to prefer changing those.
cheers, Joe
next prev parent reply other threads:[~2015-05-28 8:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 20:25 [PATCH] staging: gdm72xx: remove unneeded test Laurent Navet
2015-05-27 20:30 ` Joe Perches
2015-05-28 5:43 ` Julia Lawall
2015-05-28 5:48 ` Joe Perches
2015-05-28 16:21 ` Julia Lawall
2015-05-28 16:33 ` Joe Perches
2015-05-28 7:14 ` Dan Carpenter
2015-05-28 8:06 ` Joe Perches [this message]
2015-05-28 8:33 ` Julia Lawall
2015-05-28 8:41 ` Joe Perches
2015-05-27 20:46 ` Fabio Estevam
2015-05-28 7:20 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432800395.2846.205.camel@perches.com \
--to=joe@perches.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=laurent.navet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox