From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752917AbbE1IPx (ORCPT ); Thu, 28 May 2015 04:15:53 -0400 Received: from smtprelay0226.hostedemail.com ([216.40.44.226]:50522 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752569AbbE1IPo (ORCPT ); Thu, 28 May 2015 04:15:44 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3872:3873:4321:4384:4605:5007:6117:6261:8957:10004:10400:10848:11232:11658:11914:12043:12517:12519:12740:13069:13163:13229:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: pigs76_890903257b156 X-Filterd-Recvd-Size: 2330 Message-ID: <1432800940.2846.207.camel@perches.com> Subject: Re: [PATCH] Staging: vt6655: Remove unnecessary equality checks for a bool variable From: Joe Perches To: "Harisangam, Sharvari (S.)" Cc: "forest@alittletooquiet.net" , "gregkh@linuxfoundation.org" , "tvboxspy@gmail.com" , "gclement@baobob.org" , "haticeerturk27@gmail.com" , "mahfouz.saif.elyazal@gmail.com" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Date: Thu, 28 May 2015 01:15:40 -0700 In-Reply-To: <20150528061002.GA19430@ubuntu> References: <20150528061002.GA19430@ubuntu> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-05-28 at 06:10 +0000, Harisangam, Sharvari (S.) wrote: > Modified the if-else statements to remove unnecessary comparisons. > This change was detected with the help of coccinelle tool Your commit subject implies you are doing this for the directory, not a single file. If you are going to do this, please do it for all files in the directory. $ git grep -w -E "if\s*\(.*(true|false)" drivers/staging/vt6655/ drivers/staging/vt6655/card.c: if (pDevice->bRadioOff == true) drivers/staging/vt6655/card.c: if (pDevice->bRadioControlOff == true) { drivers/staging/vt6655/card.c: if (pDevice->bHWRadioOff == true) drivers/staging/vt6655/card.c: if (pDevice->bRadioControlOff == true) drivers/staging/vt6655/card.c: if (pDevice->bRadioOff == false) { drivers/staging/vt6655/rxtx.c: if (bRTS == true) {/* RTS_need */ drivers/staging/vt6655/rxtx.c: if (bRTS == true) {/* RTS_need */ drivers/staging/vt6655/rxtx.c: if (bRTS == true) { drivers/staging/vt6655/rxtx.c: if (bRTS == true) { /* RTS_need */