From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753769AbbE1K5z (ORCPT ); Thu, 28 May 2015 06:57:55 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:34341 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753086AbbE1K5s (ORCPT ); Thu, 28 May 2015 06:57:48 -0400 Message-ID: <1432810664.3237.135.camel@gmail.com> Subject: Re: [PATCH RESEND] sched: prefer an idle cpu vs an idle sibling for BALANCE_WAKE From: Mike Galbraith To: Morten Rasmussen Cc: Josef Bacik , "riel@redhat.com" , "mingo@redhat.com" , "peterz@infradead.org" , "linux-kernel@vger.kernel.org" Date: Thu, 28 May 2015 12:57:44 +0200 In-Reply-To: <20150528094914.GJ26396@e105550-lin.cambridge.arm.com> References: <1432761736-22093-1-git-send-email-jbacik@fb.com> <1432784798.3237.81.camel@gmail.com> <20150528094914.GJ26396@e105550-lin.cambridge.arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-05-28 at 10:49 +0100, Morten Rasmussen wrote: > Isn't sd == NULL is most cases if you don't move the sd assignment > before the affine_sd assignment? sd will usually be NULL regardless of where the assignment is, as SD_BALANCE_WAKE is usually off in ->flags. Josef is turning it on. -Mike