From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753989AbbE1Mcy (ORCPT ); Thu, 28 May 2015 08:32:54 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:33180 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753791AbbE1Mcs (ORCPT ); Thu, 28 May 2015 08:32:48 -0400 Message-ID: <1432816365.3237.168.camel@gmail.com> Subject: Re: sched_setscheduler() vs idle_balance() race From: Mike Galbraith To: Peter Zijlstra Cc: LKML , Ingo Molnar , ktkhai@parallels.com Date: Thu, 28 May 2015 14:32:45 +0200 In-Reply-To: <20150528120651.GH3644@twins.programming.kicks-ass.net> References: <1432799032.3237.119.camel@gmail.com> <20150528115118.GG3644@twins.programming.kicks-ass.net> <1432814661.3237.153.camel@gmail.com> <20150528120651.GH3644@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-05-28 at 14:06 +0200, Peter Zijlstra wrote: > On Thu, May 28, 2015 at 02:04:21PM +0200, Mike Galbraith wrote: > > On Thu, 2015-05-28 at 13:51 +0200, Peter Zijlstra wrote: > > > > Which is exactly the hole you mean, right? > > > > Yeah, but that hole is way older than dl. Box falling into it is > > running SLE11, which is.. well, still somewhat resembles 3.0. > > Oh sure, that patch just recognised there was a hole there and put a > comment in. We further failed to spot the fail you just did. Happens. Even with a perfect trap set and triggered, evidence right under my nose, I'm so used to that code that I didn't see the obvious until I took a second look.. and had that 'you dumbass' moment ;-) -Mike