From: Philipp Zabel <p.zabel@pengutronix.de>
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc: "Heiko Stübner" <heiko@sntech.de>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/9] misc: sram: fix enabled clock leak on error path
Date: Fri, 29 May 2015 17:38:22 +0200 [thread overview]
Message-ID: <1432913902.3046.9.camel@pengutronix.de> (raw)
In-Reply-To: <55684E01.70502@mentor.com>
Hi Vladimir,
Am Freitag, den 29.05.2015, 14:31 +0300 schrieb Vladimir Zapolskiy:
[...]
> > res->start is of type phys_addr_t (well, resource_size_t) already.
> > block->start/size and cur_start/size are just offsets added to it.
>
> I agree.
>
> > I wonder if it wouldn't be more appropriate to use resource_size_t for
> > the sram_reserve .start field.
>
> Assuming that the sram_reserve .start field represents only the difference
> of two res->start and this difference fits into u32 storage, it should be
> safe to keep it as is.
>
> In my opinion integer overflow case should not be considered or handled
> by the driver, so probably the best option would be just to drop
> phys_addr_t commit, since it attempts to solve a nonexistent problem.
>
> Please let me know your opinion, if it is fine with you, I'll remove
> "use phys_addr_t instead of u32 for physical address" commit and resend
> the series.
Yes, that's fine with me.
regards
Philipp
next prev parent reply other threads:[~2015-05-29 15:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 19:08 [PATCH v3 0/9] misc: sram: minor fixes and clean up Vladimir Zapolskiy
2015-05-18 19:08 ` [PATCH v3 1/9] misc: sram: fix enabled clock leak on error path Vladimir Zapolskiy
2015-05-19 10:41 ` Philipp Zabel
2015-05-19 13:11 ` Vladimir Zapolskiy
2015-05-20 11:30 ` Philipp Zabel
2015-05-24 20:12 ` Vladimir Zapolskiy
2015-05-26 8:54 ` Philipp Zabel
2015-05-29 11:31 ` Vladimir Zapolskiy
2015-05-29 15:38 ` Philipp Zabel [this message]
2015-05-18 19:08 ` [PATCH v3 2/9] misc: sram: fix device node reference leak on error Vladimir Zapolskiy
2015-05-18 19:08 ` [PATCH v3 3/9] misc: sram: use phys_addr_t instead of u32 for physical address Vladimir Zapolskiy
2015-05-19 10:38 ` Philipp Zabel
2015-05-19 12:30 ` Vladimir Zapolskiy
2015-05-18 19:08 ` [PATCH v3 4/9] misc: sram: bump error message level on unclean driver unbinding Vladimir Zapolskiy
2015-05-18 19:08 ` [PATCH v3 5/9] misc: sram: report correct SRAM pool size Vladimir Zapolskiy
2015-05-18 19:08 ` [PATCH v3 6/9] misc: sram: add private struct device and virt_base members Vladimir Zapolskiy
2015-05-18 19:08 ` [PATCH v3 7/9] misc: sram: simplify probe error path Vladimir Zapolskiy
2015-05-18 19:08 ` [PATCH v3 8/9] misc: sram: move reserved block logic out of probe function Vladimir Zapolskiy
2015-05-18 19:08 ` [PATCH v3 9/9] misc: sram: sort and clean up included headers Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432913902.3046.9.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=vladimir_zapolskiy@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox