From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1161037AbbE3FiQ (ORCPT <rfc822;w@1wt.eu>);
	Sat, 30 May 2015 01:38:16 -0400
Received: from smtprelay0213.hostedemail.com ([216.40.44.213]:59051 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1752800AbbE3FiH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 30 May 2015 01:38:07 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 30,2,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:960:966:982:988:989:1260:1261:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3872:3873:3874:4250:4321:4385:5007:6119:7652:9040:10004:10400:10848:11026:11232:11233:11658:11914:12043:12296:12517:12519:12679:12740:13069:13311:13357:13523:13524:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: mass36_297731e187d2b
X-Filterd-Recvd-Size: 2118
Message-ID: <1432964283.2984.9.camel@perches.com>
Subject: Re: [PATCH 1/4]:Add mbigen driver to support mbigen interrupt
 controller
From: Joe Perches <joe@perches.com>
To: "majun (F)" <majun258@huawei.com>
Cc: catalin Marinas <Catalin.Marinas@arm.com>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        Will Deacon <Will.Deacon@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Marc Zyngier <marc.zyngier@arm.com>
Date: Fri, 29 May 2015 22:38:03 -0700
In-Reply-To: <55692C29.60003@huawei.com>
References: <55692C29.60003@huawei.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.12.11-0ubuntu3 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 2015-05-30 at 11:19 +0800, majun (F) wrote:
> This patch contains the mbigen device driver.

Trivial notes:

Please use scripts/checkpatch.pl on your patches and see
if you want to correct any of the messages it produces.

> diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c

You could add
#define pr_fmt(fmt) "mbigen: " fmt
before any of the #includes so that all of the
pr_<level>(fmt, ...) uses are prefixed with "mbigen: "

> +int mbi_parse_irqs(struct device *dev, struct mbi_ops *ops)
> +{
> +	pr_warn("%s:this function not use now\n", __func__);

Maybe pr_warn_once()

> +	return -EINVAL;
> +}
> +EXPORT_SYMBOL(mbi_parse_irqs);
> +
> +void mbi_free_irqs(struct device *dev, unsigned int virq, unsigned int nvec)
> +{
> +	pr_warn("%s:this function not use now\n", __func__);

pr_warn_once()?

> +static struct mbigen *mbigen_get_device(struct mbigen_chip *chip,
> +										unsigned int nid)
> +{
> +	struct mbigen *tmp, *mbigen;
> +	bool found = false;
> +
> +	if (nid >= MG_NR) {
> +		pr_warn("MBIGEN: Device ID exceeds max number!\n");

So this wouldn't need a "MBIGEN: " prefix

etc...