From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757690AbbE3Kyi (ORCPT <rfc822;w@1wt.eu>);
	Sat, 30 May 2015 06:54:38 -0400
Received: from casper.infradead.org ([85.118.1.10]:41827 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750871AbbE3Kyd convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 30 May 2015 06:54:33 -0400
Message-ID: <1432983263.11346.15.camel@twins>
Subject: Re: [PATCH v3 1/4] sched/rt: Check to push the task away after its
 affinity was changed
From: Peter Zijlstra <peterz@infradead.org>
To: pang.xunlei@zte.com.cn
Cc: Juri Lelli <juri.lelli@gmail.com>, linux-kernel@vger.kernel.org,
        Ingo Molnar <mingo@redhat.com>, Xunlei Pang <pang.xunlei@linaro.org>,
        Steven Rostedt <rostedt@goodmis.org>, Xunlei Pang <xlpang@126.com>
Date: Sat, 30 May 2015 12:54:23 +0200
In-Reply-To: <20150530082035.GL19282@twins.programming.kicks-ass.net>
References: <1431442004-18716-1-git-send-email-xlpang@126.com>
	 <20150529131626.GK19282@twins.programming.kicks-ass.net>
	 <OF8BB81194.1A32A464-ON48257E54.004C068A-48257E54.004D51E2@zte.com.cn>
	 <20150530082035.GL19282@twins.programming.kicks-ass.net>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
X-Mailer: Evolution 3.10.4-0ubuntu2 
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 2015-05-30 at 10:20 +0200, Peter Zijlstra wrote:
> Makes me like the thing even less though..

Steven, why do we normally push on schedule()? Would not the natural
location be where we add to pushable_tasks?

Which would be here in set_cpus_allowed() and wakeups. schedule() seems
like a second best location.