From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758590AbbEaSjj (ORCPT ); Sun, 31 May 2015 14:39:39 -0400 Received: from smtprelay0159.hostedemail.com ([216.40.44.159]:40472 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755433AbbEaSjb (ORCPT ); Sun, 31 May 2015 14:39:31 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1567:1593:1594:1711:1714:1730:1747:1777:1792:1801:2393:2559:2562:2828:2895:3138:3139:3140:3141:3142:3622:3865:3866:3867:3868:3873:4250:4321:4605:5007:6119:6261:7903:10004:10400:10848:11232:11233:11658:11914:12438:12517:12519:12679:12740:13069:13161:13229:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: time25_52d70e3ddf054 X-Filterd-Recvd-Size: 1559 Message-ID: <1433097568.2984.31.camel@perches.com> Subject: Re: [PATCH v5 00/34] staging: rtl8192e: Fix more checkpatch.pl warnings From: Joe Perches To: Mateusz Kulikowski Cc: gregkh@linuxfoundation.org, dan.carpenter@oracle.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sun, 31 May 2015 11:39:28 -0700 In-Reply-To: <1433096393-9862-1-git-send-email-mateusz.kulikowski@gmail.com> References: <1433096393-9862-1-git-send-email-mateusz.kulikowski@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2015-05-31 at 20:19 +0200, Mateusz Kulikowski wrote: > Updated series of patches for rtl8192. [] > 31 files changed, 1260 insertions(+), 2011 deletions(-) Nice diffstat btw: If you have to resubmit this, please try to remove the unnecessary periods after logging statements. Things like: - RT_TRACE(COMP_ERR, - "PHY_SetRF8256Bandwidth(): unknown hardware version\n"); + netdev_warn(dev, "%s(): Unknown HW version.\n", + __func__); aren't sentences and don't need punctuation.