From: Paul Bolle <pebolle@tiscali.nl>
To: Xunlei Pang <xlpang@126.com>
Cc: linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
Alessandro Zummo <a.zummo@towertech.it>,
John Stultz <john.stultz@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
sparclinux@vger.kernel.org, linux-cris-kernel@axis.com,
Mikael Starvik <starvik@axis.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Xunlei Pang <pang.xunlei@linaro.org>
Subject: Re: [PATCH v2 1/4] NTP: rtc: Add CONFIG_RTC_SYSTOHC_DEVICE for NTP synchronization
Date: Mon, 01 Jun 2015 10:27:40 +0200 [thread overview]
Message-ID: <1433147260.2361.25.camel@x220> (raw)
In-Reply-To: <1432910778-314-1-git-send-email-xlpang@126.com>
On Fri, 2015-05-29 at 22:46 +0800, Xunlei Pang wrote:
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> config RTC_HCTOSYS_DEVICE
> string "RTC used to set the system time"
> - depends on RTC_HCTOSYS = y || RTC_SYSTOHC = y
> + depends on RTC_HCTOSYS = y
RTC_HCTOSYS and RTC_SYSTOHC are bool symbols. The "= y" test is not
needed and the common idiom is to use only
depends on RTC_HCTOSYS
Since you're touching this you might as well switch to that idiom.
> default "rtc0"
> help
> The RTC device that will be used to (re)initialize the system
> minutes if userspace reports synchronized NTP status.
> +config RTC_SYSTOHC_DEVICE
> + string "RTC used to synchronize NTP adjustment"
> + depends on RTC_SYSTOHC = y
Likewise.
> + default "rtc0"
> + help
> + The RTC device used for NTP synchronization. The main difference
> + between RTC_HCTOSYS_DEVICE and RTC_SYSTOHC_DEVICE is that this
> + one can sleep when setting time, because it runs in the workqueue
> + context.
Paul Bolle
next prev parent reply other threads:[~2015-06-01 8:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 14:46 [PATCH v2 1/4] NTP: rtc: Add CONFIG_RTC_SYSTOHC_DEVICE for NTP synchronization Xunlei Pang
2015-05-29 14:46 ` [PATCH v2 2/4] sparc: time: Replace update_persistent_clock() with CONFIG_RTC_SYSTOHC Xunlei Pang
2015-05-29 14:46 ` [PATCH v2 3/4] drivers/rtc/interface.c: Remove rtc_set_mmss() Xunlei Pang
2015-05-29 14:46 ` [PATCH v2 4/4] cris: time: Cleanup of persistent clock stuff Xunlei Pang
2015-06-01 8:27 ` Paul Bolle [this message]
2015-06-02 3:18 ` [PATCH v2 1/4] NTP: rtc: Add CONFIG_RTC_SYSTOHC_DEVICE for NTP synchronization pang.xunlei
-- strict thread matches above, loose matches on Subject: below --
2015-06-02 9:14 Xunlei Pang
2015-06-11 19:08 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433147260.2361.25.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=a.zummo@towertech.it \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=jesper.nilsson@axis.com \
--cc=john.stultz@linaro.org \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pang.xunlei@linaro.org \
--cc=rtc-linux@googlegroups.com \
--cc=sparclinux@vger.kernel.org \
--cc=starvik@axis.com \
--cc=xlpang@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox