linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: "majun (F)" <majun258@huawei.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
	catalin Marinas <Catalin.Marinas@arm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Will Deacon <Will.Deacon@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>
Subject: Re: [PATCH 1/4]:Add mbigen driver to support mbigen interrupt controller
Date: Mon, 01 Jun 2015 11:05:52 +0200	[thread overview]
Message-ID: <1433149552.2361.41.camel@x220> (raw)
In-Reply-To: <556C1CDC.1050508@arm.com>

On Mon, 2015-06-01 at 09:50 +0100, Marc Zyngier wrote:
> On 30/05/15 04:19, majun (F) wrote:
> > This patch contains the mbigen device driver.
> > 
> > To support Mbigen device, irq-mbigen.c and mbi.h are added.
> > 
> > As a MSI interrupt controller, the mbigen is used as a child domain of
> > MSI domain just like PCI devices.
> > 
> > Change log:
> > --irq-mbigen.c: the driver of mbigen device.The mbigen irq domain is created here
> >    as child domain of MSI.
> > --Add CONFIG_MBIGEN_IRQ_DOMAIN enable this driver

Changelog below the "---" marker, please, so git will remove it when
applying the patch.
 
> > Signed-off-by: Yun Wu <wuyun.wu@huawei.com>
> > Signed-off-by: Ma Jun <majun258@huawei.com>
> 
> Who is the author of this patch? If that's you, then the SOB lines are
> in the wrong order. If not, then there should be a From line at the top.

Even if you're the author of this patch a From: line is needed.
Otherwise "majun (F) <majun258@huawei.com>" would become the author,
instead of "Ma Jun <majun258@huawei.com>", and "majun (F)" is probably
not your name.

Thanks,


Paul Bolle


      reply	other threads:[~2015-06-01  9:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-30  3:19 [PATCH 1/4]:Add mbigen driver to support mbigen interrupt controller majun (F)
2015-05-30  5:38 ` Joe Perches
2015-05-30  6:10   ` majun (F)
2015-06-01  8:50 ` Marc Zyngier
2015-06-01  9:05   ` Paul Bolle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433149552.2361.41.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=Catalin.Marinas@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=majun258@huawei.com \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).