From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751561AbbFAJGG (ORCPT <rfc822;w@1wt.eu>);
	Mon, 1 Jun 2015 05:06:06 -0400
Received: from lb3-smtp-cloud6.xs4all.net ([194.109.24.31]:48882 "EHLO
	lb3-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1750919AbbFAJF4 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 1 Jun 2015 05:05:56 -0400
Message-ID: <1433149552.2361.41.camel@x220>
Subject: Re: [PATCH 1/4]:Add mbigen driver to support mbigen interrupt
 controller
From: Paul Bolle <pebolle@tiscali.nl>
To: "majun (F)" <majun258@huawei.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
        catalin Marinas <Catalin.Marinas@arm.com>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        Will Deacon <Will.Deacon@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>
Date: Mon, 01 Jun 2015 11:05:52 +0200
In-Reply-To: <556C1CDC.1050508@arm.com>
References: <55692C29.60003@huawei.com> <556C1CDC.1050508@arm.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2015-06-01 at 09:50 +0100, Marc Zyngier wrote:
> On 30/05/15 04:19, majun (F) wrote:
> > This patch contains the mbigen device driver.
> > 
> > To support Mbigen device, irq-mbigen.c and mbi.h are added.
> > 
> > As a MSI interrupt controller, the mbigen is used as a child domain of
> > MSI domain just like PCI devices.
> > 
> > Change log:
> > --irq-mbigen.c: the driver of mbigen device.The mbigen irq domain is created here
> >    as child domain of MSI.
> > --Add CONFIG_MBIGEN_IRQ_DOMAIN enable this driver

Changelog below the "---" marker, please, so git will remove it when
applying the patch.
 
> > Signed-off-by: Yun Wu <wuyun.wu@huawei.com>
> > Signed-off-by: Ma Jun <majun258@huawei.com>
> 
> Who is the author of this patch? If that's you, then the SOB lines are
> in the wrong order. If not, then there should be a From line at the top.

Even if you're the author of this patch a From: line is needed.
Otherwise "majun (F) <majun258@huawei.com>" would become the author,
instead of "Ma Jun <majun258@huawei.com>", and "majun (F)" is probably
not your name.

Thanks,


Paul Bolle