Re: [PATCH v7 1/4] ASoC: arizona: Export functions to control subsystem DVFS

Mark Brown
2015-06-01T16:36:20Z

[-- Attachment #1: Type: text/plain, Size: 739 bytes --]

On Mon, Jun 01, 2015 at 05:22:51PM +0100, Richard Fitzgerald wrote:
> On Mon, Jun 01, 2015 at 05:10:47PM +0100, Mark Brown wrote:

> > > + if (priv->dvfs_reqs)
> > > + ret = arizona_dvfs_disable(codec);

> > Are you sure that the function shouldn't check for requests? It seems
> > like every caller is repeating the same check.

> Sorry, I don't understand your comment here. When SYSCLK is disabled
> we need to disable DVFS so that the codec can't go into suspend in the
> illegal state of DVFS enabled but insifficient DCVDD. However, if
> dvfs_reqs==0 DVFS is already disabled so we can save some time.

Sure, but you repeat the same tests for dvfs_reqs at every call site
which suggests it should be factored into the functions.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]