public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Petr Mladek <pmladek@suse.cz>
Cc: Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Make the output better readable
Date: Mon, 01 Jun 2015 08:50:24 -0700	[thread overview]
Message-ID: <1433173824.4861.8.camel@perches.com> (raw)
In-Reply-To: <1433168737-17009-1-git-send-email-pmladek@suse.cz>

On Mon, 2015-06-01 at 16:25 +0200, Petr Mladek wrote:
> I always have troubles to parse checkpatch.pl output when I check
> the whole patchset. It is hard to say which messages belongs to
> what patch.
> 
> This patch does few small changes to make the output look better
> for me:
> 
>     + delimit each patch from each other with dashes and empty line
>     + remove empty line after the summary

I've no objection about this, but don't much care either.

>     + print message about false positives only once

This bit seems sensible, thanks.

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -720,8 +720,14 @@ my @fixed_deleted = ();
>  my $fixlinenr = -1;
>  
>  my $vname;
> +my $filenum = 0;
>  for my $filename (@ARGV) {
>  	my $FILE;
> +
> +	if ($filenum++ && $quiet == 0) {
> +		print "--------------------------------------------------------------------------------\n";

Perhaps more perlish would be print '-' x 81 . '\n\n';
Dunno why you chose 81 though, it seems an unusual number.



  reply	other threads:[~2015-06-01 15:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-01 14:25 [PATCH] checkpatch: Make the output better readable Petr Mladek
2015-06-01 15:50 ` Joe Perches [this message]
2015-06-02  9:13   ` Petr Mladek
2015-06-02  9:52     ` Joe Perches
2015-06-02 10:44       ` Petr Mladek
2015-06-02 20:49         ` Joe Perches
2015-06-01 18:02 ` Joe Perches
     [not found]   ` <CA+r1ZhjhF-n4Q2kfiV6mx1aUqbZNycNTJBkTgLTq9KivsawvdA@mail.gmail.com>
2015-06-01 18:22     ` Joe Perches
2015-06-02  9:26   ` Petr Mladek
2015-06-02  9:54     ` Joe Perches
2015-06-02 10:53     ` Rasmus Villemoes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433173824.4861.8.camel@perches.com \
    --to=joe@perches.com \
    --cc=apw@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox