From: Joe Perches <joe@perches.com>
To: Moritz Fischer <moritz.fischer@ettus.com>
Cc: jassisinghbrar@gmail.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
michal.simek@xilinx.com, soren.brinkmann@xilinx.com,
akpm@linux-foundation.org, gregkh@linuxfoundation.org,
mchehab@osg.samsung.com, arnd@arndb.de, jingoohan1@gmail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv4 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.
Date: Mon, 01 Jun 2015 09:32:30 -0700 [thread overview]
Message-ID: <1433176350.4861.21.camel@perches.com> (raw)
In-Reply-To: <1433175507-3833-3-git-send-email-moritz.fischer@ettus.com>
On Mon, 2015-06-01 at 09:18 -0700, Moritz Fischer wrote:
> The Xilinx LogiCORE IP mailbox is a FPGA core that allows for
> interprocessor communication via AXI4 memory mapped / AXI4 stream
> interfaces.
trivia:
> diff --git a/drivers/mailbox/mailbox-xilinx.c b/drivers/mailbox/mailbox-xilinx.c
[]
> +static int xilinx_mbox_startup(struct mbox_chan *chan)
> +{
[]
> + dev_err(mbox->dev,
> + "failed to register mailbox interrupt:%d\n",
> + ret);
[]
> +static int xilinx_mbox_probe(struct platform_device *pdev)
> +{
[]
> + dev_err(&pdev->dev, "Couldn't get clk.\n");
[]
> + dev_info(&pdev->dev, "IRQ not found, fallback to polling.\n");
[]
> + dev_err(&pdev->dev, "Register mailbox failed\n");
Perhaps it' be nicer to consistently use a "no-period"
message style.
next prev parent reply other threads:[~2015-06-01 16:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 16:18 [PATCHv4 0/2] Adding driver for Xilinx LogiCORE IP mailbox Moritz Fischer
2015-06-01 16:18 ` [PATCHv4 1/2] dts: Adding docs for Xilinx LogiCORE IP mailbox driver Moritz Fischer
2015-06-16 18:45 ` Josh Cartwright
2015-06-01 16:18 ` [PATCHv4 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox Moritz Fischer
2015-06-01 16:32 ` Joe Perches [this message]
2015-06-16 18:44 ` Josh Cartwright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433176350.4861.21.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jassisinghbrar@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@osg.samsung.com \
--cc=michal.simek@xilinx.com \
--cc=moritz.fischer@ettus.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox