From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759451AbbFBQuF (ORCPT ); Tue, 2 Jun 2015 12:50:05 -0400 Received: from mga02.intel.com ([134.134.136.20]:17691 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759556AbbFBQt5 (ORCPT ); Tue, 2 Jun 2015 12:49:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,540,1427785200"; d="scan'208";a="735740144" Message-ID: <1433263793.26331.42.camel@linux.intel.com> Subject: Re: [PATCH 1/1] x86/microcode: vsnprintf() might be unavailable From: Andy Shevchenko To: Borislav Petkov Cc: Ingo Molnar , linux-kernel@vger.kernel.org Date: Tue, 02 Jun 2015 19:49:53 +0300 In-Reply-To: <20150602162403.GD20576@pd.tnic> References: <1433257003-159485-1-git-send-email-andriy.shevchenko@linux.intel.com> <20150602162403.GD20576@pd.tnic> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-06-02 at 18:24 +0200, Borislav Petkov wrote: > On Tue, Jun 02, 2015 at 05:56:43PM +0300, Andy Shevchenko wrote: > > On Intel CPUs with x32 kernels we call load_builtin_intel_microcode() from > > head_32.S on quite earlier stage. At that point sprintf() might be out of scope > > to be called. > > Hrrm, I don't get that. How can sprintf() be out of scope? Initial paging setup is involved? I just sent a small update to previous patch. Please, look at it. > > Testing on 32-bit was successful here. How is x32 different? Hmm… which Intel CPUs you run on? Ah, one more thing we run our kernel from kexec (I hope it's not a case, but who knows). > > Thanks. > -- Andy Shevchenko Intel Finland Oy