From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751877AbbFBVmN (ORCPT ); Tue, 2 Jun 2015 17:42:13 -0400 Received: from smtprelay0142.hostedemail.com ([216.40.44.142]:45533 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751105AbbFBVmJ (ORCPT ); Tue, 2 Jun 2015 17:42:09 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1981:2194:2199:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3874:4250:4321:5007:6119:6120:6261:7901:7903:10004:10400:10848:11026:11232:11658:11914:12517:12519:12555:12740:13069:13311:13357:21060:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: shirt89_2e7cd05798b41 X-Filterd-Recvd-Size: 2563 Message-ID: <1433281318.4861.105.camel@perches.com> Subject: Re: [PATCH 2/2] time: allow gcc to fold constants when possible From: Joe Perches To: John Stultz Cc: Thomas Gleixner , Nicholas Mc Guire , Michal Marek , Masahiro Yamada , Sam Ravnborg , "H. Peter Alvin" , Andrew Hunter , Paul Turner , lkml Date: Tue, 02 Jun 2015 14:41:58 -0700 In-Reply-To: References: <1432832996-12129-1-git-send-email-hofrat@osadl.org> <1432832996-12129-2-git-send-email-hofrat@osadl.org> <1432836156.2846.237.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-06-02 at 14:31 -0700, John Stultz wrote: > On Tue, Jun 2, 2015 at 2:23 PM, Thomas Gleixner wrote: > > On Thu, 28 May 2015, Joe Perches wrote: > >> On Thu, 2015-05-28 at 19:09 +0200, Nicholas Mc Guire wrote: > >> > To allow constant folding in usecs_to_jiffies() conditionally calls > >> > the HZ dependent _usecs_to_jiffies() helpers or, when gcc can not > >> > figure out constant folding, __usecs_to_jiffies, which is the renamed > >> > original usecs_to_jiffies() function. > >> > >> Hi Nicholas. > >> > >> Thanks for following through with this. > >> > >> The subject might be nicer if it referenced usecs_to_jiffies > >> instead of being a bit generic. > >> > >> Maybe something like: > >> > >> time: allow gcc to fold usecs_to_jiffies(constant) > > > > And for correctness sake the first letter after the colon, i.e. the > > one starting the sentence wants to be uppercase. > > Is this something that would be worth adding to checkpatch? Probably not as different people have different standards. $ git log --no-merges --pretty=oneline -10000 | \ cut -f2- -d" " | \ sed -r -e 's/^.*:\s+//' -e 's/^(.).*/\1/' | \ sort | uniq -c It's about 50:50 upper case to lower case