From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965372AbbFCRQ7 (ORCPT ); Wed, 3 Jun 2015 13:16:59 -0400 Received: from smtprelay0030.hostedemail.com ([216.40.44.30]:45425 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965340AbbFCRQs (ORCPT ); Wed, 3 Jun 2015 13:16:48 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:968:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2559:2562:2828:2895:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3872:3874:4321:4605:5007:6248:6261:7903:10004:10400:10848:11026:11232:11473:11658:11914:12517:12519:12740:13069:13161:13229:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: train27_75374c381a520 X-Filterd-Recvd-Size: 2439 Message-ID: <1433351804.4861.134.camel@perches.com> Subject: Re: [lustre-devel] [PATCH v3 6/7] staging:lustre: style cleanups for lib-socket.c From: Joe Perches To: "Simmons, James A." Cc: James Simmons , "devel@driverdev.osuosl.org" , "HPDD-discuss@lists.01.org" , Greg Kroah-Hartman , Linux Kernel Mailing List , Oleg Drokin , "lustre-devel@lists.lustre.org" Date: Wed, 03 Jun 2015 10:16:44 -0700 In-Reply-To: References: <1433341954-654-1-git-send-email-jsimmons@infradead.org> <1433341954-654-7-git-send-email-jsimmons@infradead.org> <1433342574.4861.126.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-06-03 at 17:12 +0000, Simmons, James A. wrote: > >On Wed, 2015-06-03 at 10:32 -0400, James Simmons wrote: > >> Handle all the style issues reported by checkpatch.pl. > >> Remove general white spaces, spaces in function calls, > >> etc. > >[] > >> @@ -167,13 +164,14 @@ lnet_ipif_enumerate (char ***namesp) > >> if (nalloc * sizeof(*ifr) > PAGE_CACHE_SIZE) { > >> toobig = 1; > >> nalloc = PAGE_CACHE_SIZE/sizeof(*ifr); > >> - CWARN("Too many interfaces: only enumerating first %d\n", > >> - nalloc); > >> + CWARN("Too many interfaces: only enumerating " > >> + "first %d\n", nalloc); > > > >Please don't split single strings into multiple parts. > > > >For a patch like this it'd be nice to specify that both > >"git diff -w" and scripts/objdiff shows no differences. > > > >Unless it does... > > Two patches have mistakes. Should I send a new series or do a in-reply instead. Most of the time, it's better to send a new series. If any of the unmodified patches are very large, like 100KB+, then it can be better to send individually updated patches.