From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755744AbbFCUVF (ORCPT ); Wed, 3 Jun 2015 16:21:05 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:36679 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752997AbbFCUU7 (ORCPT ); Wed, 3 Jun 2015 16:20:59 -0400 From: Tolga Ceylan To: Oleg Drokin , Andreas Dilger , Greg Kroah-Hartman , Julia Lawall , Arjun AK , Greg Donald , Darshana Padmadas , Tolga Ceylan , Joe Perches , HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/1] staging: lustre/lustre/obdclass/llog_cat.c: get rid of sparse context imbalance warning Date: Wed, 3 Jun 2015 13:20:10 -0700 Message-Id: <1433362810-14176-1-git-send-email-tolga.ceylan@gmail.com> X-Mailer: git-send-email 2.4.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In llog_cat_new_log(), sparse emits a context imbalance (unexpected lock) warning due its inability to detect the noreturn attribute in lbug_with_lock() function inside LBUG macro. With this patch, we unlock the spinlock before checking the error condition to resolve this warning. Signed-off-by: Tolga Ceylan --- drivers/staging/lustre/lustre/obdclass/llog_cat.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/llog_cat.c b/drivers/staging/lustre/lustre/obdclass/llog_cat.c index c8f6ab0..280e861 100644 --- a/drivers/staging/lustre/lustre/obdclass/llog_cat.c +++ b/drivers/staging/lustre/lustre/obdclass/llog_cat.c @@ -103,13 +103,13 @@ static int llog_cat_new_log(const struct lu_env *env, spin_lock(&loghandle->lgh_hdr_lock); llh->llh_count++; - if (ext2_set_bit(index, llh->llh_bitmap)) { + rc = ext2_set_bit(index, llh->llh_bitmap); + spin_unlock(&loghandle->lgh_hdr_lock); + if (rc) { CERROR("argh, index %u already set in log bitmap?\n", index); - spin_unlock(&loghandle->lgh_hdr_lock); LBUG(); /* should never happen */ } - spin_unlock(&loghandle->lgh_hdr_lock); cathandle->lgh_last_idx = index; llh->llh_tail.lrt_index = index; -- 2.4.2