From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Adrian Hunter <adrian.hunter@intel.com>,
David Ahern <dsahern@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
Namhyung Kim <namhyung@kernel.org>
Subject: [PATCH 3/6] perf machine: Fix the search for the kernel DSO on the unified list
Date: Wed, 3 Jun 2015 19:40:35 -0300 [thread overview]
Message-ID: <1433371238-14572-4-git-send-email-acme@kernel.org> (raw)
In-Reply-To: <1433371238-14572-1-git-send-email-acme@kernel.org>
From: Arnaldo Carvalho de Melo <acme@redhat.com>
When unifying the user_dsos and kernel_dsos a bug was introduced by
inverting the check for dso->kernel, fix it.
Fixes: 3d39ac538629 ("perf machine: No need to have two DSOs lists")
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/n/tip-xnrnq0kams3s2z9ek1wjb506@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/machine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index 2ed61f59d415..4e29e80932e5 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c
@@ -1149,7 +1149,7 @@ static int machine__process_kernel_mmap_event(struct machine *machine,
struct dso *dso;
list_for_each_entry(dso, &machine->dsos.head, node) {
- if (dso->kernel && is_kernel_module(dso->long_name))
+ if (!dso->kernel || is_kernel_module(dso->long_name))
continue;
kernel = dso;
--
2.1.0
next prev parent reply other threads:[~2015-06-03 22:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 22:40 [GIT PULL 0/6] perf/core improvements and fixes Arnaldo Carvalho de Melo
2015-06-03 22:40 ` [PATCH 1/6] perf probe: Fix segfault when glob matching function without debuginfo Arnaldo Carvalho de Melo
2015-06-03 22:40 ` [PATCH 2/6] perf tools: Remove newline char when reading event scale and unit Arnaldo Carvalho de Melo
2015-06-03 22:40 ` Arnaldo Carvalho de Melo [this message]
2015-06-03 22:40 ` [PATCH 4/6] perf tools: Move linux/kernel.h to tools/include Arnaldo Carvalho de Melo
2015-06-03 22:40 ` [PATCH 5/6] tools: Move tools/perf/util/include/linux/{list.h,poison.h} " Arnaldo Carvalho de Melo
2015-06-03 22:40 ` [PATCH 6/6] perf tools: Deal with kernel module names in '[]' correctly Arnaldo Carvalho de Melo
2015-06-04 5:48 ` [GIT PULL 0/6] perf/core improvements and fixes Ingo Molnar
2015-06-04 6:07 ` Wangnan (F)
2015-06-04 7:21 ` Ingo Molnar
2015-06-04 10:00 ` Wangnan (F)
2015-06-04 12:40 ` Ingo Molnar
2015-06-04 12:58 ` pi3orama
2015-06-04 14:04 ` Ingo Molnar
2015-06-04 16:22 ` Alexei Starovoitov
2015-06-04 21:48 ` Masami Hiramatsu
2015-06-04 22:07 ` Alexei Starovoitov
2015-06-05 6:41 ` Ingo Molnar
2015-06-05 8:53 ` Wangnan (F)
2015-06-05 12:05 ` Ingo Molnar
2015-06-05 14:06 ` Arnaldo Carvalho de Melo
2015-06-07 13:11 ` Ingo Molnar
2015-06-05 13:59 ` Arnaldo Carvalho de Melo
2015-06-04 10:17 ` [EXPERIENCE] My experience on using perf record BPF filter on a real usecase Wangnan (F)
2015-06-10 6:42 ` Alexei Starovoitov
2015-06-10 6:48 ` Wangnan (F)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433371238-14572-4-git-send-email-acme@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).