From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752818AbbFDMM2 (ORCPT ); Thu, 4 Jun 2015 08:12:28 -0400 Received: from smtprelay0147.hostedemail.com ([216.40.44.147]:33933 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751860AbbFDMM1 (ORCPT ); Thu, 4 Jun 2015 08:12:27 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:4321:5007:6119:6261:7903:7904:8603:10004:10400:10848:11026:11658:11914:12043:12296:12438:12517:12519:12740:13069:13095:13311:13357:13972:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: bath73_8969146c09823 X-Filterd-Recvd-Size: 1722 Message-ID: <1433419943.4861.167.camel@perches.com> Subject: Re: [PATCH] staging: fbtft: fix out of bound access From: Joe Perches To: Sudip Mukherjee Cc: Thomas Petazzoni , Noralf =?ISO-8859-1?Q?Tr=F8nnes?= , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Thu, 04 Jun 2015 05:12:23 -0700 In-Reply-To: <1433418121-9434-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1433418121-9434-1-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-06-04 at 17:12 +0530, Sudip Mukherjee wrote: > size of str is 16, but in snprintf the size was mentioned as 128. [] > diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c [] > @@ -1096,7 +1096,7 @@ static int fbtft_init_display_dt(struct fbtft_par *par) > /* make debug message */ > msg[0] = '\0'; > for (j = 0; j < i; j++) { > - snprintf(str, 128, " %02X", buf[j]); > + snprintf(str, 16, " %02X", buf[j]); using sizeof(str) is probably more robust msg isn't big enough to hold the maximum possible output. If this is really useful, and I rather doubt it is, it'd probably be better to use a loop to output multiple lines, one for each register.