public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
	"Noralf Trønnes" <noralf@tronnes.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: fbtft: fix out of bound access
Date: Thu, 04 Jun 2015 13:48:31 -0700	[thread overview]
Message-ID: <1433450911.2658.6.camel@perches.com> (raw)
In-Reply-To: <1433424892-23333-1-git-send-email-sudipm.mukherjee@gmail.com>

On Thu, 2015-06-04 at 19:04 +0530, Sudip Mukherjee wrote:
> str was 16 bytes but was mentioned as 128 in snprintf.
> again msg is 128 bytes but not sufficient to hold the complete debug
> message of register values.
> Now removed the use of str, msg and print the register values from the
> loop.
[]
> v2: removed the use of msg and str.

It's nice to cc the people that give you suggestions when
you send a new version of a patch.

> diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
[]
> @@ -1067,8 +1067,6 @@ static int fbtft_init_display_dt(struct fbtft_par *par)
>  	const __be32 *p;
>  	u32 val;
>  	int buf[64], i, j;
[]
>  			par->fbtftops.write_register(par, i,
>  				buf[0], buf[1], buf[2], buf[3],

It seems there are only 2 callers of (*write_register)()
and the arguments are always an in-order array int[64]

Maybe it'd be nicer to change the prototypes of the
write_register functions to take a const int * 
instead of pushing 64 ints on the stack.


  reply	other threads:[~2015-06-04 20:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-04 13:34 [PATCH v2] staging: fbtft: fix out of bound access Sudip Mukherjee
2015-06-04 20:48 ` Joe Perches [this message]
2015-06-05  4:52   ` Sudip Mukherjee
2015-06-05  5:46     ` Joe Perches
2015-06-08 14:52       ` Sudip Mukherjee
2015-06-08 15:57         ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433450911.2658.6.camel@perches.com \
    --to=joe@perches.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noralf@tronnes.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox