public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Romain Baeriswyl" <romain.baeriswyl@alitech.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
	"Alexandre Courbot" <gnurou@gmail.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Christian Ruppert" <christian.ruppert@alitech.com>,
	"Anton Vorontsov" <cbouatmailru@gmail.com>,
	"Rojhalat Ibrahim" <imr@rtschenk.de>,
	"abdoulaye berthe" <berthe.ab@gmail.com>,
	"Anthony Fee" <anthony.fee@emutex.com>
Subject: Re: [PATCH] added device tree support to gpio-generic driver
Date: Fri, 05 Jun 2015 10:17:27 +0300	[thread overview]
Message-ID: <1433488647.404966286@f385.i.mail.ru> (raw)
In-Reply-To: <1433487062-10647-1-git-send-email-romain.baeriswyl@alitech.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 775 bytes --]

Пятница,  5 июня 2015, 8:51 +02:00 от Romain Baeriswyl <romain.baeriswyl@alitech.com>:
> ---
>  .../devicetree/bindings/gpio/gpio-generic.txt      |   19 +++++
>  drivers/gpio/gpio-generic.c                        |   81 ++++++++++++++-----
>  2 files changed, 78 insertions(+), 22 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-generic.txt

Hello.

...
> diff --git a/drivers/gpio/gpio-generic.c b/drivers/gpio/gpio-generic.c
...
> +		if (of_property_read_u32(dev->of_node, "base", &pdata->base))
> +			pdata->base = -1;

The "base" property is excessive for DT.

---

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

  reply	other threads:[~2015-06-05  7:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05  6:51 [PATCH] added device tree support to gpio-generic driver Romain Baeriswyl
2015-06-05  7:17 ` Alexander Shiyan [this message]
2015-06-08  4:19 ` Alexandre Courbot
2015-06-08  6:26   ` Romain Baeriswyl
2015-06-08  6:39     ` Alexandre Courbot
2015-06-24  7:42   ` Romain Baeriswyl
2015-06-10  8:42 ` Linus Walleij
2015-06-11 10:32   ` [PATCH V2] " Romain Baeriswyl
2015-06-11 10:42     ` Alexander Shiyan
2015-06-11 11:40       ` Sascha Hauer
2015-06-16  9:15     ` Linus Walleij
2015-06-24  9:54       ` [PATCH V3] " Romain Baeriswyl
2015-06-24 11:55         ` Masahiro Yamada
2015-06-24 11:07   ` [PATCH] " Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433488647.404966286@f385.i.mail.ru \
    --to=shc_work@mail.ru \
    --cc=anthony.fee@emutex.com \
    --cc=berthe.ab@gmail.com \
    --cc=cbouatmailru@gmail.com \
    --cc=christian.ruppert@alitech.com \
    --cc=gnurou@gmail.com \
    --cc=imr@rtschenk.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=romain.baeriswyl@alitech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox