From: Joerg Roedel <joro@8bytes.org>
To: Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Vivek Goyal <vgoyal@redhat.com>, Dave Young <dyoung@redhat.com>,
Baoquan He <bhe@redhat.com>,
x86@kernel.org, kexec@lists.infradead.org, joro@8bytes.org,
jroedel@suse.de, linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] x86, crash: Allocate enough low-mem when crashkernel=high
Date: Fri, 5 Jun 2015 12:30:02 +0200 [thread overview]
Message-ID: <1433500202-25531-4-git-send-email-joro@8bytes.org> (raw)
In-Reply-To: <1433500202-25531-1-git-send-email-joro@8bytes.org>
From: Joerg Roedel <jroedel@suse.de>
When the crashkernel is loaded above 4GiB in memory the
first kernel only allocates 72MiB of low-memory for the DMA
requirements of the second kernel. On systems with many
devices this is not enough and causes device driver
initialization errors and failed crash dumps. Testing by
SUSE and Redhat have shown that 256MiB is a good default
value for now and the discussion has agreed on this value as
well. So set this default value to 256MiB to make sure there
is enough memory available for DMA.
Acked-by: Baoquan He <bhe@redhat.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
---
arch/x86/kernel/setup.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index d74ac33..a09f368 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -535,8 +535,11 @@ static void __init reserve_crashkernel_low(void)
* swiotlb overflow buffer: now is hardcoded to 32k.
* We round it to 8M for other buffers that
* may need to stay low too.
+ * Also make sure we allocate enough extra memory
+ * low memory so that we don't run out of DMA
+ * buffers for 32bit devices.
*/
- low_size = swiotlb_size_or_default() + (8UL<<20);
+ low_size = max(swiotlb_size_or_default() + (8UL<<20), 256UL<<20);
auto_set = true;
} else {
/* passed with crashkernel=0,low ? */
--
1.9.1
next prev parent reply other threads:[~2015-06-05 10:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 10:29 [PATCH 0/3 v3] Fix kdump failures with crashkernel=high Joerg Roedel
2015-06-05 10:30 ` [PATCH 1/3] swiotlb: Warn on allocation failure in swiotlb_alloc_coherent Joerg Roedel
2015-06-12 8:49 ` [tip:x86/kdump] swiotlb: Warn on allocation failure in swiotlb_alloc_coherent() tip-bot for Joerg Roedel
2015-06-05 10:30 ` [PATCH 2/3] x86, swiotlb: Try coherent allocations with __GFP_NOWARN Joerg Roedel
2015-06-12 8:50 ` [tip:x86/kdump] x86/swiotlb: " tip-bot for Joerg Roedel
2015-06-05 10:30 ` Joerg Roedel [this message]
2015-06-12 8:50 ` [tip:x86/kdump] x86/crash: Allocate enough low memory when crashkernel=high tip-bot for Joerg Roedel
2015-06-05 13:27 ` [PATCH 0/3 v3] Fix kdump failures with crashkernel=high Borislav Petkov
2015-06-07 13:41 ` Ingo Molnar
2015-06-07 14:38 ` Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2015-01-06 14:51 [PATCH 0/3 v2] " Joerg Roedel
2015-01-06 14:51 ` [PATCH 3/3] x86, crash: Allocate enough low-mem when crashkernel=high Joerg Roedel
2015-01-23 8:44 ` Baoquan He
2015-01-26 12:07 ` Joerg Roedel
2015-02-01 8:41 ` Baoquan He
2015-02-04 14:10 ` Joerg Roedel
2015-02-09 12:20 ` Joerg Roedel
2015-02-13 15:34 ` Baoquan He
2015-02-13 22:28 ` Joerg Roedel
2015-02-14 11:44 ` Baoquan He
2015-01-23 17:02 ` Borislav Petkov
2015-01-26 12:11 ` Joerg Roedel
2015-01-26 12:20 ` Borislav Petkov
2015-01-26 12:40 ` Joerg Roedel
2015-01-26 12:45 ` Borislav Petkov
2014-11-28 11:29 [PATCH 0/3] Fix kdump failures with crashkernel=high Joerg Roedel
2014-11-28 11:29 ` [PATCH 3/3] x86, crash: Allocate enough low-mem when crashkernel=high Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433500202-25531-4-git-send-email-joro@8bytes.org \
--to=joro@8bytes.org \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=jroedel@suse.de \
--cc=kexec@lists.infradead.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).