From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423441AbbFEPHs (ORCPT ); Fri, 5 Jun 2015 11:07:48 -0400 Received: from smtprelay0246.hostedemail.com ([216.40.44.246]:43930 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1422692AbbFEPHn (ORCPT ); Fri, 5 Jun 2015 11:07:43 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3873:3874:4321:5007:6119:6261:7903:10004:10400:10848:11232:11658:11914:12517:12519:12740:13069:13095:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: cloth43_7d09672857c2b X-Filterd-Recvd-Size: 1916 Message-ID: <1433516858.2658.44.camel@perches.com> Subject: Re: [PATCH 5/6] power: user: Standardize "Syncing filesystems ..." message From: Joe Perches To: Pavel Machek Cc: linux-pm@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , linux-kernel@vger.kernel.org Date: Fri, 05 Jun 2015 08:07:38 -0700 In-Reply-To: <20150605103727.GA6054@amd> References: <06fdc51c7d2ab639729107a137b947704fd7d161.1433442778.git.joe@perches.com> <20150605103727.GA6054@amd> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-06-05 at 12:37 +0200, Pavel Machek wrote: > On Thu 2015-06-04 11:36:48, Joe Perches wrote: > > Instead of a two individual printks that would generally be > > emitted on a single line, emit 2 lines to make the start > > and end of the synchronization more easily timeable. [] > > diff --git a/kernel/power/user.c b/kernel/power/user.c [] > > @@ -221,9 +221,9 @@ static long snapshot_ioctl(struct file *filp, unsigned int cmd, > > if (data->frozen) > > break; > > > > - printk("Syncing filesystems ... "); > > + printk("Syncing filesystems ...\n"); > > sys_sync(); > > - printk("done.\n"); > > + printk("Syncing filesystems: done\n"); > > You converted " ..." -> "..." elsewhere, so why not here? Missed that one. > Is splitting message to two lines a good idea? I think the "done" is unnecessary actually. As there's no newline on the first, printk is async and can be interleaved by other threads.