From: Joe Perches <joe@perches.com>
To: Shailendra Verma <shailendra.capricorn@gmail.com>
Cc: Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts:checkpatch - correct the error message during check
Date: Fri, 05 Jun 2015 08:15:57 -0700 [thread overview]
Message-ID: <1433517357.2658.47.camel@perches.com> (raw)
In-Reply-To: <1433512519-2810-1-git-send-email-shailendra.capricorn@gmail.com>
On Fri, 2015-06-05 at 19:25 +0530, Shailendra Verma wrote:
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3169,21 +3169,21 @@ sub process {
> }
>
> # check for global initialisers.
> - if ($line =~ /^\+$Type\s*$Ident(?:\s+$Modifier)*\s*=\s*(?:0|NULL|false)\s*;/) {
> + if ($line =~ /^\+$Type\s*$Ident(?:\s+$Modifier)*\s*=\s*(?:0x0|0|NULL|false)\s*;/) {
> if (ERROR("GLOBAL_INITIALISERS",
> - "do not initialise globals to 0 or NULL\n" .
> + "do not initialise globals to $2\n" .
The first capture group in the old and broken regex
was unnecessary and was removed so s/$2/$1/
next prev parent reply other threads:[~2015-06-05 15:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 13:55 [PATCH] scripts:checkpatch - correct the error message during check Shailendra Verma
2015-06-05 15:15 ` Joe Perches [this message]
[not found] ` <CA+tKcn9Mc-s=bD3KPQ=E=+yB=Sgx65yi6EUE_Qe7OiC4JCzEJg@mail.gmail.com>
2015-06-05 15:40 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2015-06-05 17:10 Shailendra Verma
[not found] <no@samsung.com>
2015-10-30 11:25 ` shailendra.v
2015-10-30 12:56 ` Andy Whitcroft
2015-10-30 15:29 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433517357.2658.47.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shailendra.capricorn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox