From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754875AbbFEPQB (ORCPT ); Fri, 5 Jun 2015 11:16:01 -0400 Received: from smtprelay0033.hostedemail.com ([216.40.44.33]:34874 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754661AbbFEPQA (ORCPT ); Fri, 5 Jun 2015 11:16:00 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:968:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1568:1593:1594:1711:1714:1730:1747:1777:1792:2197:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3653:3865:3867:3868:3870:4321:5007:6261:10004:10400:10848:11658:11914:12043:12517:12519:12740:13069:13161:13229:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: burn14_34292308dd761 X-Filterd-Recvd-Size: 1503 Message-ID: <1433517357.2658.47.camel@perches.com> Subject: Re: [PATCH] scripts:checkpatch - correct the error message during check From: Joe Perches To: Shailendra Verma Cc: Andy Whitcroft , linux-kernel@vger.kernel.org Date: Fri, 05 Jun 2015 08:15:57 -0700 In-Reply-To: <1433512519-2810-1-git-send-email-shailendra.capricorn@gmail.com> References: <1433512519-2810-1-git-send-email-shailendra.capricorn@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-06-05 at 19:25 +0530, Shailendra Verma wrote: > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -3169,21 +3169,21 @@ sub process { > } > > # check for global initialisers. > - if ($line =~ /^\+$Type\s*$Ident(?:\s+$Modifier)*\s*=\s*(?:0|NULL|false)\s*;/) { > + if ($line =~ /^\+$Type\s*$Ident(?:\s+$Modifier)*\s*=\s*(?:0x0|0|NULL|false)\s*;/) { > if (ERROR("GLOBAL_INITIALISERS", > - "do not initialise globals to 0 or NULL\n" . > + "do not initialise globals to $2\n" . The first capture group in the old and broken regex was unnecessary and was removed so s/$2/$1/