From: Paul Bolle <pebolle@tiscali.nl>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: Jean-Baptiste Theou <jtheou@adeneo-embedded.us>,
Wim Van Sebroeck <wim@iguana.be>,
Guenter Roeck <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] gpio_wdt: Add option for early registration
Date: Sat, 06 Jun 2015 16:11:18 +0200 [thread overview]
Message-ID: <1433599878.10861.82.camel@x220> (raw)
In-Reply-To: <20150606125611.GA16930@nebuchadnezzar>
On Sat, 2015-06-06 at 14:56 +0200, Valentin Rothberg wrote:
> On Sat, Jun 06, 2015 at 12:03:06PM +0200, Paul Bolle wrote:
> > On Sat, 2015-06-06 at 00:46 -0700, Jean-Baptiste Theou wrote:
> > > +#ifdef GPIO_WATCHDOG_ARCH_INITCALL
> >
> > You meant
> > #ifdef CONFIG_GPIO_WATCHDOG_ARCH_INITCALL
> >
> > Please use scripts/checkkconfigsymbols.py.
>
> checkkconfigsymbols.py only checks CONFIG_ prefix symbols. Since this
> prefix is missing here, the script would not complain.
Of course. Thanks for correcting me.
> But that's an interesting case and worth checking for.
Perhaps. Depends on the amount of false positives that such checks would
trigger, I'd say.
Paul Bolle
next prev parent reply other threads:[~2015-06-06 14:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-06 7:46 [PATCH v3 1/2] watchdog_core: Add watchdog registration deferral mechanism Jean-Baptiste Theou
2015-06-06 7:46 ` [PATCH v3 2/2] gpio_wdt: Add option for early registration Jean-Baptiste Theou
2015-06-06 10:03 ` Paul Bolle
2015-06-06 12:56 ` Valentin Rothberg
2015-06-06 14:11 ` Paul Bolle [this message]
2015-06-06 16:19 ` Jean-Baptiste Theou
2015-06-06 17:00 ` Guenter Roeck
2015-06-06 17:00 ` [PATCH v3 1/2] watchdog_core: Add watchdog registration deferral mechanism Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433599878.10861.82.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=jtheou@adeneo-embedded.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=valentinrothberg@gmail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox