[PATCH] irqchip: sunxi-nmi: Fix off-by-one for iterating over gc->num_ct

[PATCH] irqchip: sunxi-nmi: Fix off-by-one for iterating over gc->num_ct

[Axel Lin]

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/irqchip/irq-sunxi-nmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-sunxi-nmi.c b/drivers/irqchip/irq-sunxi-nmi.c
index 12f547a..eb9b59e 100644
--- a/drivers/irqchip/irq-sunxi-nmi.c
+++ b/drivers/irqchip/irq-sunxi-nmi.c
@@ -104,7 +104,7 @@ static int sunxi_sc_nmi_set_type(struct irq_data *data, unsigned int flow_type)
 	irqd_set_trigger_type(data, flow_type);
 	irq_setup_alt_chip(data, flow_type);
 
-	for (i = 0; i <= gc->num_ct; i++, ct++)
+	for (i = 0; i < gc->num_ct; i++, ct++)
 		if (ct->type & flow_type)
 			ctrl_off = ct->regs.type;
 
-- 
1.8.3.2

Re: [PATCH] irqchip: sunxi-nmi: Fix off-by-one for iterating over gc->num_ct

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

On Sun, Jun 07, 2015 at 09:33:29PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] irqchip: sunxi-nmi: Fix off-by-one for iterating over gc->num_ct

[Carlo Caione]

On Sun, Jun 7, 2015 at 3:33 PM, Axel Lin <axel.lin@ingics.com> wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/irqchip/irq-sunxi-nmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-sunxi-nmi.c b/drivers/irqchip/irq-sunxi-nmi.c
> index 12f547a..eb9b59e 100644
> --- a/drivers/irqchip/irq-sunxi-nmi.c
> +++ b/drivers/irqchip/irq-sunxi-nmi.c
> @@ -104,7 +104,7 @@ static int sunxi_sc_nmi_set_type(struct irq_data *data, unsigned int flow_type)
>         irqd_set_trigger_type(data, flow_type);
>         irq_setup_alt_chip(data, flow_type);
>
> -       for (i = 0; i <= gc->num_ct; i++, ct++)
> +       for (i = 0; i < gc->num_ct; i++, ct++)
>                 if (ct->type & flow_type)
>                         ctrl_off = ct->regs.type;

Acked-by: Carlo Caione <carlo@endlessm.com>

-- 
Carlo Caione

[tip:irq/urgent] irqchip: sunxi-nmi: Fix off-by-one error in irq iterator

[tip-bot for Axel Lin]

Commit-ID:  febe06962ab191db50e633a0f79d9fb89a2d1078
Gitweb:     http://git.kernel.org/tip/febe06962ab191db50e633a0f79d9fb89a2d1078
Author:     Axel Lin <axel.lin@ingics.com>
AuthorDate: Sun, 7 Jun 2015 21:33:29 +0800
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 8 Jun 2015 10:08:50 +0200

irqchip: sunxi-nmi: Fix off-by-one error in irq iterator

Fixes: 6058bb362818 'ARM: sun7i/sun6i: irqchip: Add irqchip driver for NMI controller'
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Carlo Caione <carlo@caione.org>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/1433684009.9134.1.camel@ingics.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/irqchip/irq-sunxi-nmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-sunxi-nmi.c b/drivers/irqchip/irq-sunxi-nmi.c
index 4a9ce5b..6b2b582 100644
--- a/drivers/irqchip/irq-sunxi-nmi.c
+++ b/drivers/irqchip/irq-sunxi-nmi.c
@@ -104,7 +104,7 @@ static int sunxi_sc_nmi_set_type(struct irq_data *data, unsigned int flow_type)
 	irqd_set_trigger_type(data, flow_type);
 	irq_setup_alt_chip(data, flow_type);
 
-	for (i = 0; i <= gc->num_ct; i++, ct++)
+	for (i = 0; i < gc->num_ct; i++, ct++)
 		if (ct->type & flow_type)
 			ctrl_off = ct->regs.type;