Re: [PATCH] irqchip: sunxi-nmi: Fix off-by-one for iterating over gc->num_ct

Carlo Caione
2015-06-08T08:12:40Z

On Sun, Jun 7, 2015 at 3:33 PM, Axel Lin <axel.lin@ingics.com> wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/irqchip/irq-sunxi-nmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-sunxi-nmi.c b/drivers/irqchip/irq-sunxi-nmi.c
> index 12f547a..eb9b59e 100644
> --- a/drivers/irqchip/irq-sunxi-nmi.c
> +++ b/drivers/irqchip/irq-sunxi-nmi.c
> @@ -104,7 +104,7 @@ static int sunxi_sc_nmi_set_type(struct irq_data *data, unsigned int flow_type)
> irqd_set_trigger_type(data, flow_type);
> irq_setup_alt_chip(data, flow_type);
>
> - for (i = 0; i <= gc->num_ct; i++, ct++)
> + for (i = 0; i < gc->num_ct; i++, ct++)
> if (ct->type & flow_type)
> ctrl_off = ct->regs.type;

Acked-by: Carlo Caione <carlo@endlessm.com>

--
Carlo Caione