From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932159AbbFHT6A (ORCPT ); Mon, 8 Jun 2015 15:58:00 -0400 Received: from smtprelay0029.hostedemail.com ([216.40.44.29]:56489 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752363AbbFHT5x (ORCPT ); Mon, 8 Jun 2015 15:57:53 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2911:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3874:4321:4425:4605:5007:6261:6755:7903:8957:10004:10400:10848:11232:11658:11914:12043:12219:12295:12517:12519:12555:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: soap99_44733716b1059 X-Filterd-Recvd-Size: 2313 Message-ID: <1433793469.2730.5.camel@perches.com> Subject: Re: [PATCH v4 1/7] staging:lustre: move tcpip abstraction From: Joe Perches To: Greg Kroah-Hartman , Jonathan Corbet , linux-doc@vger.kernel.org Cc: James Simmons , devel@driverdev.osuosl.org, Oleg Drokin , Andreas Dilger , Linux Kernel Mailing List , lustre-devel@lists.lustre.org Date: Mon, 08 Jun 2015 12:57:49 -0700 In-Reply-To: <20150608193359.GA1001@kroah.com> References: <1433361433-24976-1-git-send-email-jsimmons@infradead.org> <1433361433-24976-2-git-send-email-jsimmons@infradead.org> <20150608193359.GA1001@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-06-08 at 12:33 -0700, Greg Kroah-Hartman wrote: > Please generate patches in -M format, so I can see the rename properly, > as it is, this is too messy for me to review. Adding this to the .gitconfig works too [diff] renames = true That should probably be mentioned in SubmittingPatches. Something like: --- Documentation/SubmittingPatches | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 27e7e5e..d86cf89 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -715,6 +715,13 @@ the top of the kernel source tree and don't use too much horizontal space (easily fit in 80 columns, maybe with some indentation). (git generates appropriate diffstats by default.) +Another good thing is to generate shorter patches whenever a file rename +has been done. Using "git format-patch -M" does this appropriately. +Adding a [diff] section as below to .gitconfig can also do this: + + [diff] + renames = true + See more details on the proper patch format in the following references.