From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752691AbbFHXXg (ORCPT ); Mon, 8 Jun 2015 19:23:36 -0400 Received: from smtprelay0053.hostedemail.com ([216.40.44.53]:48393 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751888AbbFHXX1 (ORCPT ); Mon, 8 Jun 2015 19:23:27 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2551:2553:2559:2562:2691:2692:2828:2892:2899:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:4321:5007:6117:6261:7903:10004:10400:10450:10455:10848:11232:11658:11914:12050:12517:12519:12663:12740:13069:13161:13191:13192:13229:13255:13311:13357:19904:19999:21063:21080:21088,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: base62_752b1c0657822 X-Filterd-Recvd-Size: 2255 Message-ID: <1433805804.2730.22.camel@perches.com> Subject: Re: [PATCH 1/6] power: hibernate: Use separate messages for "Syncing filesystems" From: Joe Perches To: "Rafael J. Wysocki" Cc: linux-pm@vger.kernel.org, Len Brown , Pavel Machek , linux-kernel@vger.kernel.org Date: Mon, 08 Jun 2015 16:23:24 -0700 In-Reply-To: <5609150.OAJVFt04xE@vostro.rjw.lan> References: <1664a8ea72b34db4bef860004166875ab70898ee.1433442778.git.joe@perches.com> <5609150.OAJVFt04xE@vostro.rjw.lan> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-06-09 at 01:35 +0200, Rafael J. Wysocki wrote: > On Thursday, June 04, 2015 11:36:44 AM Joe Perches wrote: > > Add the ability to see how long it takes to sync the filesystems > > via the printk time mechanism. > > > > Start to standardize the printk "PM: doing something...done" > > messages on two separate lines. > > Well, it would be good to say what problem this is attempting to fix. > > And while I understand the underlying concern, there is a merit in keeping > each of these messages in one line (if everything goes well), so I'm wondering > what about printing each of them in one go after the operation with a tail > depending on the result? Like > > printk(KERN_INFO "PM: Syncing filesystems ... done\n"); > > on success or > > printk(KERN_INFO "PM: Syncing filesystems ... failed\n"); > > on failure? Maybe. I believe there are multi-second delays possible when syncing the filesystems on things like usb memory sticks. I think the dmesg line count here isn't particularly important and there's some small value in consistently presenting timing information via dmesg timestamps when using 2 lines. There's also some small value in patch 6/6 and the consistent prefixing of "PM: " on all these messages.