Re: [PATCH -next] selftests/ipc: Consolidate posix and sysv msg queue tests

Shuah Khan
2015-06-17T21:09:46Z

On 06/09/2015 10:23 AM, Davidlohr Bueso wrote:
> On Tue, 2015-06-09 at 06:55 -0600, Shuah Khan wrote
>>> diff --git a/tools/testing/selftests/ipc/.gitignore b/tools/testing/selftests/ipc/.gitignore
>>> new file mode 100644
>>> index 0000000..3d8a449
>>> --- /dev/null
>>> +++ b/tools/testing/selftests/ipc/.gitignore
>>> @@ -0,0 +1,3 @@
>>> +mqueue/mq_open_tests
>>> +mqueue/mq_perf_tests
>>> +msg/msgque_test
>>> diff --git a/tools/testing/selftests/ipc/Makefile b/tools/testing/selftests/ipc/Makefile
>>> index 25d2e70..8686551 100644
>>> --- a/tools/testing/selftests/ipc/Makefile
>>> +++ b/tools/testing/selftests/ipc/Makefile
>>> @@ -1,22 +1,22 @@
>>> -uname_M := $(shell uname -m 2>/dev/null || echo not)
>>> -ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/)
>>> -ifeq ($(ARCH),i386)
>>> - ARCH := x86
>>> - CFLAGS := -DCONFIG_X86_32 -D__i386__
>>> -endif
>>> -ifeq ($(ARCH),x86_64)
>>> - ARCH := x86
>>> - CFLAGS := -DCONFIG_X86_64 -D__x86_64__
>>> -endif
>>> -
>>> -CFLAGS += -I../../../../usr/include/
>>
>> Hmm. This looks like more than a moving code and cleanup change.
>> The above is removing special handling for x86 and x86_64.
>>
>> I would like to see this as a separate patch and not combined
>> with the moving code.
>
> No, this is merely being moved to msg/Makefile, see below:
>

I was just about to queue this patch up for 4.2. However, with this
patch mqueue test no longer builds and runs. This is because of the
consolidation. If you intend to continue to run, you will have to
add ipc to the selftests Makefile TARGETS instead of mqueue, provided
you would want ipc to be part of the run-tests target.

Build phase:
make[2]: Entering directory
'/mnt/data/lkml/linux-kselftest/tools/testing/selftests/mqueue'
make[2]: *** No rule to make target 'run_tests'. Stop

run-tests phase:
make[2]: Entering directory
'/mnt/data/lkml/linux-kselftest/tools/testing/selftests/mqueue'
make[2]: *** No rule to make target 'run_tests'. Stop.
make[2]: Leaving directory
'/mnt/data/lkml/linux-kselftest/tools/testing/selftests/mqueue'

Also install won't install any ipc binaries since ipc isn't in the
TARGETS.

thanks,
-- Shuah

--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978