From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933501AbbFJKSS (ORCPT ); Wed, 10 Jun 2015 06:18:18 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:39656 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933418AbbFJKSP (ORCPT ); Wed, 10 Jun 2015 06:18:15 -0400 X-Originating-IP: 83.155.44.161 Message-ID: <1433931490.5707.18.camel@hadess.net> Subject: Re: [PATCH] Input: goodix - do not explicitly set evbits in input device From: Bastien Nocera To: Dmitry Torokhov Cc: Irina Tirdea , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 10 Jun 2015 12:18:10 +0200 In-Reply-To: <20150609185219.GA33366@dtor-ws> References: <20150609185219.GA33366@dtor-ws> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.2.1 (3.16.2.1-1.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-06-09 at 11:52 -0700, Dmitry Torokhov wrote: > input_mt_init_slots() will do that for us. I'm guessing you know what you're doing here, but I couldn't find where the EV_SYN bit would have been set in the input_mt_init_slots() call chain. > Signed-off-by: Dmitry Torokhov > --- > drivers/input/touchscreen/goodix.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/input/touchscreen/goodix.c > b/drivers/input/touchscreen/goodix.c > index 73ade35..b4d12e2 100644 > --- a/drivers/input/touchscreen/goodix.c > +++ b/drivers/input/touchscreen/goodix.c > @@ -301,10 +301,6 @@ static int goodix_request_input_dev(struct > goodix_ts_data *ts, u16 version, > return -ENOMEM; > } > > - ts->input_dev->evbit[0] = BIT_MASK(EV_SYN) | > - BIT_MASK(EV_KEY) | > - BIT_MASK(EV_ABS); > - > input_set_abs_params(ts->input_dev, ABS_MT_POSITION_X, > 0, ts->abs_x_max, 0, 0); > input_set_abs_params(ts->input_dev, ABS_MT_POSITION_Y, > -- > 2.2.0.rc0.207.ga3a616c > >