From: Joe Perches <joe@perches.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, jkosina@suse.cz,
paulmck@linux.vnet.ibm.com, pmladek@suse.cz,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC][PATCH] printk: Fixup the nmi printk mess
Date: Wed, 10 Jun 2015 09:19:16 -0700 [thread overview]
Message-ID: <1433953156.32331.4.camel@perches.com> (raw)
In-Reply-To: <20150610120242.1e33c752@gandalf.local.home>
On Wed, 2015-06-10 at 12:02 -0400, Steven Rostedt wrote:
> BTW, the printk.c file is getting rather big.
No joke that.
> Can we make a
> kernel/printk/nmi.c file that does this work. We can add a local
> printk_common.h that can share the global data structures, and this
> would move most of the #ifdef out of the C files.
Yes please.
There are many things in printk that could be moved
into separate files.
The last time I tried this was before Kay's structured
printk logging stuff:
https://lkml.org/lkml/2012/10/24/748
next prev parent reply other threads:[~2015-06-10 16:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 12:55 [RFC][PATCH] printk: Fixup the nmi printk mess Peter Zijlstra
2015-06-10 14:31 ` Petr Mladek
2015-06-10 14:57 ` Petr Mladek
2015-06-10 15:32 ` Peter Zijlstra
2015-06-10 15:54 ` Steven Rostedt
2015-06-10 15:29 ` Peter Zijlstra
2015-06-10 19:23 ` Peter Zijlstra
2015-06-10 19:36 ` Peter Zijlstra
2015-06-10 19:36 ` Steven Rostedt
2015-06-11 14:55 ` Petr Mladek
2015-06-12 12:00 ` Peter Zijlstra
2015-06-12 14:28 ` Petr Mladek
2015-06-12 15:35 ` Petr Mladek
2015-06-25 18:14 ` Peter Zijlstra
2015-06-26 8:06 ` Petr Mladek
2015-06-11 9:57 ` Petr Mladek
2015-06-10 15:53 ` Steven Rostedt
2015-06-10 16:02 ` Steven Rostedt
2015-06-10 16:19 ` Joe Perches [this message]
2015-06-10 19:25 ` Peter Zijlstra
2015-06-10 19:35 ` Steven Rostedt
2015-06-10 19:39 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433953156.32331.4.camel@perches.com \
--to=joe@perches.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.cz \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox