Re: [PATCH 2/4] iommu/vt-d: Don't consider copied context entries as present

[David Woodhouse <dwmw2@infradead.org>]

[-- Attachment #1: Type: text/plain, Size: 2529 bytes --]

On Thu, 2015-06-11 at 15:44 +0100, David Woodhouse wrote:
> It used to look like this
> ...
> Now it looks like this

That's not quite right; each root entry is for only *one* bus, and the
correct version looks more like this...

It used to look like this:

Root Table Address Register
       |
       V

Root Table (struct root_entry)     Context Table (struct context_entry)
------------------------------     ------------------------------------
0x00: CTX TBL for bus #0 --------->  CTX entry for 00:00.0 (bits 63-0)
0x08: unused                         CTX entry for 00:00.0 (bits 127-64)
0x10: CTX TBL for bus #1 ----.       CTX entry for 00:00.1 (bits 63-0)
...   ...                    |       ...
0xff8:unused                 |       CTX entry for 00:1f.7 (bits 127-64)
                             |
                             |
                             |     Context Table (struct context_entry)
                             |     ------------------------------------
0x00:                        ----->  CTX entry for 01:00.0 (bits 63-0)
0x00:                                CTX entry for 01:00.0 (bits 127-64)
0x08:                                CTX entry for 01:00.1 (bits 63-0)
...                                  ...
0xff8:                               CTX entry for 01:1f.7 (bits 127-64)


Now it looks like this, with each context entry taking twice the amount
of space:

Root Table Address Register
       |
       V

Root Table (struct root_entry)     Context Table (struct context_entry)
------------------------------     ------------------------------------
0x00: CTX TBL LO for bus #0 ------>  CTX entry for 00:00.0 (bits 63-0)
0x08: CTX TBL HI for bus #0 --.      CTX entry for 00:00.0 (bits 127-64)
0x10: CTX TBL LO for bus #1   |      CTX entry for 00:00.0 (bits 191-128)
...   ...                     |      ...
0xff8:CTX TBL HI for bus #FF  |      CTX entry for 00:0f.7 (bits 255-192)
                              |
                              |
                              |    Context Table (struct context_entry)
                              |    ------------------------------------
0x00:                         ---->  CTX entry for 00:10.0 (bits 63-0)
0x00:                                CTX entry for 00:10.0 (bits 127-64)
0x08:                                CTX entry for 00:10.0 (bits 191-128)
...                                  ...
0xff8:                               CTX entry for 00:1f.7 (bits 63-0)

-- 
dwmw2

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5691 bytes --]