public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: KOBAYASHI Yoshitake <yoshitake.kobayashi@toshiba.co.jp>
Cc: dwmw2@infradead.org, computersforpeace@gmail.com,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mtd: nand: support for Toshiba BENAND (Built-in ECC NAND)
Date: Fri, 12 Jun 2015 10:11:02 +0200	[thread overview]
Message-ID: <1434096662.2271.130.camel@x220> (raw)
In-Reply-To: <1434038402-26365-1-git-send-email-yoshitake.kobayashi@toshiba.co.jp>

On Fri, 2015-06-12 at 01:00 +0900, KOBAYASHI Yoshitake wrote:
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index 5897d8d..050f0e9 100644

> +config MTD_NAND_BENAND
> +	tristate
> +	depends on MTD_NAND_BENAND_ENABLE
> +	default MTD_NAND
> +
> +config MTD_NAND_BENAND_ENABLE
> +	bool "Support for Toshiba BENAND (Built-in ECC NAND)"
> +	default y

Why do you default to 'y'?

> +	help
> +		This enables support for Toshiba BENAND.
> +		Toshiba BENAND is a SLC NAND solution that automatically
> +		generates ECC inside NAND chip.
> +

> --- /dev/null
> +++ b/drivers/mtd/nand/nand_benand.c

> +EXPORT_SYMBOL(nand_benand_status_chk);

I didn't spot any users of nand_benand_status_chk() outside of this
file. Why is this export needed?

Thanks,


Paul Bolle


  reply	other threads:[~2015-06-12  8:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-11 16:00 [PATCH v2] mtd: nand: support for Toshiba BENAND (Built-in ECC NAND) KOBAYASHI Yoshitake
2015-06-12  8:11 ` Paul Bolle [this message]
2015-06-16 13:37   ` KOBAYASHI Yoshitake
2015-06-12  9:49 ` Richard Weinberger
2015-06-16 13:33   ` KOBAYASHI Yoshitake
2015-06-16 13:53     ` Richard Weinberger
2015-06-19 14:46       ` KOBAYASHI Yoshitake
2015-07-24 17:42 ` [PATCH REPOST v3] mtd: nand " KOBAYASHI Yoshitake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434096662.2271.130.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=yoshitake.kobayashi@toshiba.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox