From: Pawel Moll <pawel.moll@arm.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Andi Kleen <ak@linux.intel.com>, Ingo Molnar <mingo@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jiri Olsa <jolsa@redhat.com>,
Stephane Eranian <eranian@google.com>,
"mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>
Subject: Re: [RFC PATCH] perf: Add PERF_RECORD_SWITCH to indicate context switches
Date: Fri, 12 Jun 2015 14:28:33 +0100 [thread overview]
Message-ID: <1434115713.1484.9.camel@arm.com> (raw)
In-Reply-To: <557ADB6E.8080604@intel.com>
On Fri, 2015-06-12 at 14:15 +0100, Adrian Hunter wrote:
> >>>> all 3 are already part of sample_id.
> >>>
> >>> You have to decide whether you expect to be able to use an event without
> >>> sample_id. MMAP and MMAP2 both have pid, tid which are in sample_id, LOST
> >>> has id, EXIT and FORK have time, all of the THROTTLE/UNTHROTTLE members are
> >>> in sample_id etc. So it currently looks like we expect to be able to use an
> >>> event without requiring sample_id.
> >
> > The fact that there is this duplication is because sample_id_all came
> > after those events, but this new one being proposed doesn't have to do
> > it :-)
>
> Thanks, that's clear then. There will just need to be a flag to indicate
> whether it is scheduling in or out.
Just a thought: wouldn't it be good to know what CPU have we been
scheduled from/to? This kind of information would be especially valuable
in heterogeneous systems.
Pawel
next prev parent reply other threads:[~2015-06-12 13:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 14:21 [RFC PATCH] perf: Add PERF_RECORD_SWITCH to indicate context switches Adrian Hunter
2015-06-11 14:15 ` Peter Zijlstra
2015-06-11 16:34 ` Andi Kleen
2015-06-11 16:54 ` Peter Zijlstra
2015-06-12 0:47 ` David Ahern
2015-06-12 10:34 ` Adrian Hunter
2015-06-12 14:21 ` David Ahern
2015-06-12 16:13 ` Adrian Hunter
2015-06-12 11:12 ` Adrian Hunter
2015-06-12 12:09 ` Peter Zijlstra
2015-06-12 12:36 ` Arnaldo Carvalho de Melo
2015-06-12 13:15 ` Adrian Hunter
2015-06-12 13:28 ` Pawel Moll [this message]
2015-06-12 13:52 ` Pawel Moll
2015-06-12 14:30 ` David Ahern
2015-06-12 14:29 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434115713.1484.9.camel@arm.com \
--to=pawel.moll@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox