From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Drew Richardson <drew.richardson@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
John Stultz <john.stultz@linaro.org>,
Wade Cherry <Wade.Cherry@arm.com>,
Pawel Moll <Pawel.Moll@arm.com>
Subject: Re: [PATCH] ftrace: Provide trace clock monotonic raw
Date: Fri, 8 May 2015 01:27:56 +0000 (UTC) [thread overview]
Message-ID: <1434206731.45802.1431048476130.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <20150507204228.0cb8b55c@grimm.local.home>
----- Original Message -----
> On Tue, 5 May 2015 07:54:46 -0700
> Drew Richardson <drew.richardson@arm.com> wrote:
>
> > CLOCK_MONOTONIC_RAW will advance more constantly than CLOCK_MONOTONIC.
> >
> > Imagine someone is trying to optimize a particular program to reduce
> > instructions executed for a given workload while minimizing the effect
> > on runtime. Also suppose that ntp is running and potentially making
> > larger adjustments to CLOCK_MONOTONIC. If ntp is adjusting
> > CLOCK_MONOTONIC to advance more rapidly, the program will appear to
> > use fewer instructions per second but run longer than it would if
> > CLOCK_MONOTONIC_RAW had been used. The total number of instructions
> > observed would be the same regardless of the clock source used, but
> > how it's attributed to time would be affected.
> >
> > Conversely if ntp is adjusting CLOCK_MONOTONIC to advance more slowly,
> > the program will appear to use more instructions per second but run
> > more quickly. Of course there are many sources that can cause jitter
> > in performance measurements on modern processors, but I'd like to
> > remove ntp from the list.
>
> What's the consensus on this patch? Everyone OK with it? If so, can you
> please post a new patch with the proper change log. And can everyone
> else give acks. I can take it in my tree.
I can see it being useful for tracing early boot, e.g.
when debugging issues with NTP. So adding it to ftrace
makes sense to me.
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2015-05-08 1:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 14:41 [PATCH] ftrace: Provide trace clock monotonic raw Drew Richardson
2015-05-04 15:10 ` Mathieu Desnoyers
2015-05-04 20:05 ` Drew Richardson
2015-05-04 20:47 ` John Stultz
2015-05-04 20:57 ` Peter Zijlstra
2015-05-05 14:54 ` Drew Richardson
2015-05-08 0:42 ` Steven Rostedt
2015-05-08 1:27 ` Mathieu Desnoyers [this message]
2015-05-08 14:09 ` Steven Rostedt
2015-05-08 14:29 ` Drew Richardson
2015-05-08 14:30 ` [PATCHv3] " Drew Richardson
2015-05-08 14:41 ` Steven Rostedt
2015-05-08 16:05 ` John Stultz
2015-05-08 16:15 ` Steven Rostedt
2015-05-08 16:21 ` John Stultz
2015-05-08 16:11 ` Peter Zijlstra
2015-05-12 14:26 ` Thomas Gleixner
2015-05-12 19:59 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434206731.45802.1431048476130.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=Pawel.Moll@arm.com \
--cc=Wade.Cherry@arm.com \
--cc=drew.richardson@arm.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox