Re: [PATCH 03/30] perf tools: Change thread_map::map into struct

Jiri Olsa
2015-06-15T21:33:47Z

On Mon, Jun 15, 2015 at 04:04:04PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sun, Jun 14, 2015 at 10:19:18AM +0200, Jiri Olsa escreveu:
> > We need to store command names with the pid. Changing
> > map to be struct holding pid. Process name is coming
> > in shortly.
>
> <SNIP>
>
> > +++ b/tools/perf/util/thread_map.h
> > @@ -4,11 +4,17 @@
> > #include <sys/types.h>
> > #include <stdio.h>
> >
> > +struct thread_map_data {
> > + pid_t pid;
> > +};
> > +
>
> What 'data' is this? That is way vague term.

data related to thread_mmap ;-)

jirka

>
> Will try looking at the other patches to try to suggest some other name
> for this :-\
>
> > struct thread_map {
> > int nr;
> > - pid_t map[];
> > + struct thread_map_data map[];
> > };
> >
> > +#define thread_map__pid(__m, __t) __m->map[__t].pid
> > +
> > struct thread_map *thread_map__new_dummy(void);
> > struct thread_map *thread_map__new_by_pid(pid_t pid);
> > struct thread_map *thread_map__new_by_tid(pid_t tid);
> > --
> > 1.9.3